All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: George Cherian <george.cherian@ti.com>,
	tony@atomide.com, bcousson@baylibre.com
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm
Date: Fri, 6 Jun 2014 01:53:10 -0500	[thread overview]
Message-ID: <53916556.10608@ti.com> (raw)
In-Reply-To: <1402035454-25676-1-git-send-email-george.cherian@ti.com>

On 06/06/2014 01:17 AM, George Cherian wrote:
> AM437x EPOS evm use external clock for RMII interface.
> Enable the same in DT. 
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> Reported-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index 19f1f7e..90098f9 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -319,6 +319,10 @@
>  	phy-mode = "rmii";
>  };
>  
> +&phy_sel {
> +	rmii-clock-ext;
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  	pinctrl-names = "default";
> 
Where does this apply on?
With linux-next next-20140506 tag, and this patch applied, I get the
following error.

  LD      kernel/trace/built-in.o
  LD      kernel/built-in.o
build fail, Error:
Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path,
'phy_sel', not found
FATAL ERROR: Syntax error parsing input tree
make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [dtbs] Error 2
make: *** Waiting for unfinished jobs....

in the future, it is helpful if you can point out that this is a
regression seen on next-20140603 and the patch needs to be applied on
some specific branch.

for the record:
last working next tag:
https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt

first broken next tag:
https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt


-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm
Date: Fri, 6 Jun 2014 01:53:10 -0500	[thread overview]
Message-ID: <53916556.10608@ti.com> (raw)
In-Reply-To: <1402035454-25676-1-git-send-email-george.cherian@ti.com>

On 06/06/2014 01:17 AM, George Cherian wrote:
> AM437x EPOS evm use external clock for RMII interface.
> Enable the same in DT. 
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> Reported-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index 19f1f7e..90098f9 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -319,6 +319,10 @@
>  	phy-mode = "rmii";
>  };
>  
> +&phy_sel {
> +	rmii-clock-ext;
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  	pinctrl-names = "default";
> 
Where does this apply on?
With linux-next next-20140506 tag, and this patch applied, I get the
following error.

  LD      kernel/trace/built-in.o
  LD      kernel/built-in.o
build fail, Error:
Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path,
'phy_sel', not found
FATAL ERROR: Syntax error parsing input tree
make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [dtbs] Error 2
make: *** Waiting for unfinished jobs....

in the future, it is helpful if you can point out that this is a
regression seen on next-20140603 and the patch needs to be applied on
some specific branch.

for the record:
last working next tag:
https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt

first broken next tag:
https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt


-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: George Cherian <george.cherian@ti.com>, <tony@atomide.com>,
	<bcousson@baylibre.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm
Date: Fri, 6 Jun 2014 01:53:10 -0500	[thread overview]
Message-ID: <53916556.10608@ti.com> (raw)
In-Reply-To: <1402035454-25676-1-git-send-email-george.cherian@ti.com>

On 06/06/2014 01:17 AM, George Cherian wrote:
> AM437x EPOS evm use external clock for RMII interface.
> Enable the same in DT. 
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> Reported-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index 19f1f7e..90098f9 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -319,6 +319,10 @@
>  	phy-mode = "rmii";
>  };
>  
> +&phy_sel {
> +	rmii-clock-ext;
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  	pinctrl-names = "default";
> 
Where does this apply on?
With linux-next next-20140506 tag, and this patch applied, I get the
following error.

  LD      kernel/trace/built-in.o
  LD      kernel/built-in.o
build fail, Error:
Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path,
'phy_sel', not found
FATAL ERROR: Syntax error parsing input tree
make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [dtbs] Error 2
make: *** Waiting for unfinished jobs....

in the future, it is helpful if you can point out that this is a
regression seen on next-20140603 and the patch needs to be applied on
some specific branch.

for the record:
last working next tag:
https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt

first broken next tag:
https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt


-- 
Regards,
Nishanth Menon

  reply	other threads:[~2014-06-06  6:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  6:17 [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm George Cherian
2014-06-06  6:17 ` George Cherian
2014-06-06  6:17 ` George Cherian
2014-06-06  6:53 ` Nishanth Menon [this message]
2014-06-06  6:53   ` Nishanth Menon
2014-06-06  6:53   ` Nishanth Menon
     [not found]   ` <53916556.10608-l0cyMroinI0@public.gmane.org>
2014-06-06  6:55     ` Nishanth Menon
2014-06-06  6:55       ` Nishanth Menon
2014-06-06  6:55       ` Nishanth Menon
2014-06-06  9:56       ` George Cherian
2014-06-06  9:56         ` George Cherian
2014-06-06  9:56         ` George Cherian
2014-06-06  9:52     ` George Cherian
2014-06-06  9:52       ` George Cherian
2014-06-06  9:52       ` George Cherian
     [not found]       ` <53918F75.1050000-l0cyMroinI0@public.gmane.org>
2014-06-06 15:28         ` Nishanth Menon
2014-06-06 15:28           ` Nishanth Menon
2014-06-06 15:28           ` Nishanth Menon
     [not found]           ` <5391DE01.2080600-l0cyMroinI0@public.gmane.org>
2014-06-16 12:03             ` Tony Lindgren
2014-06-16 12:03               ` Tony Lindgren
2014-06-16 12:03               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53916556.10608@ti.com \
    --to=nm@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.