* [PATCH] be2iscsi: add an missing goto in error path
@ 2014-06-06 12:06 Tomas Henzl
2014-06-06 14:08 ` Christoph Hellwig
2014-06-06 17:04 ` Michael Christie
0 siblings, 2 replies; 3+ messages in thread
From: Tomas Henzl @ 2014-06-06 12:06 UTC (permalink / raw)
To: 'linux-scsi@vger.kernel.org'; +Cc: jayamohank, sony.john-n
a jump to 'free_memory' is apparently missing
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index ac54cf5..442982d 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba)
kfree(phba->ep_array);
phba->ep_array = NULL;
ret = -ENOMEM;
+
+ goto free_memory;
}
for (i = 0; i < phba->params.cxns_per_ctrl; i++) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] be2iscsi: add an missing goto in error path
2014-06-06 12:06 [PATCH] be2iscsi: add an missing goto in error path Tomas Henzl
@ 2014-06-06 14:08 ` Christoph Hellwig
2014-06-06 17:04 ` Michael Christie
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2014-06-06 14:08 UTC (permalink / raw)
To: Tomas Henzl; +Cc: 'linux-scsi@vger.kernel.org', jayamohank, sony.john-n
On Fri, Jun 06, 2014 at 02:06:30PM +0200, Tomas Henzl wrote:
> a jump to 'free_memory' is apparently missing
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] be2iscsi: add an missing goto in error path
2014-06-06 12:06 [PATCH] be2iscsi: add an missing goto in error path Tomas Henzl
2014-06-06 14:08 ` Christoph Hellwig
@ 2014-06-06 17:04 ` Michael Christie
1 sibling, 0 replies; 3+ messages in thread
From: Michael Christie @ 2014-06-06 17:04 UTC (permalink / raw)
To: Tomas Henzl; +Cc: linux-scsi@vger.kernel.org, jayamohank, sony.john-n
On Jun 6, 2014, at 7:06 AM, Tomas Henzl <thenzl@redhat.com> wrote:
> a jump to 'free_memory' is apparently missing
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index ac54cf5..442982d 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba)
> kfree(phba->ep_array);
> phba->ep_array = NULL;
> ret = -ENOMEM;
> +
> + goto free_memory;
> }
>
> for (i = 0; i < phba->params.cxns_per_ctrl; i++) {
> —
Thanks.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-06 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-06 12:06 [PATCH] be2iscsi: add an missing goto in error path Tomas Henzl
2014-06-06 14:08 ` Christoph Hellwig
2014-06-06 17:04 ` Michael Christie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.