From: Chris Metcalf <cmetcalf@tilera.com>
To: Peter Zijlstra <peterz@infradead.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Davidlohr Bueso <davidlohr@hp.com>, <mingo@kernel.org>,
<mpatocka@redhat.com>, <torvalds@linux-foundation.org>,
<jason.low2@hp.com>, <waiman.long@hp.com>,
<jejb@parisc-linux.org>, <paulmck@linux.vnet.ibm.com>,
<dave.anglin@bell.net>, <aswin@hp.com>,
<linux-kernel@vger.kernel.org>, <linux-parisc@vger.kernel.org>,
<davem@davemloft.net>, <james.hogan@imgtec.com>,
<vgupta@synopsys.com>
Subject: Re: [PATCH 2/2] locking/rwsem: Disable optimistic spinning for PA-RISC
Date: Fri, 6 Jun 2014 13:19:59 -0400 [thread overview]
Message-ID: <5391F83F.60005@tilera.com> (raw)
In-Reply-To: <20140606171145.GU13930@laptop.programming.kicks-ass.net>
On 6/6/2014 1:11 PM, Peter Zijlstra wrote:
> The thing is, all these archs are broken beyond this particular problem,
> Mikulas Patocka found a number of other spots.
>
> In any case, sure I can exclude more. Although ideally someone goes do
> that __atomic sparse thing to flush out all this.
>
> ---
> Subject: locking, mutex: Disable optimistic spinning on !RMW archs
>
> For some archs a regular store does not play nice with cmpxchg(), the
> optimistic spinning code (and various other places not caught by this)
> break this assumption and make things go boom.
>
> Until something better is found, disable optimistic spinning for these
> archs.
>
> [..]
>
> +config ARCH_NO_ATOMIC_RMW
> + def_bool y
> + depends on PARISC || SPARC32 || METAG_ATOMICITY_LOCK1 || (TILE && !TILEGX) || (ARC && !ARC_HAS_LLSC)
For tile:
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
But you should use "TILEPRO" (added in kernel 3.5) instead of "(TILE && !TILEGX)".
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2014-06-06 17:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 15:55 [PATCH 0/2] locking/rwsem: disable optimistic spinning for PA-RISC Davidlohr Bueso
2014-06-06 15:55 ` [PATCH 1/2] locking/rwsem: Add CONFIG_RWSEM_SPIN_ON_OWNER Davidlohr Bueso
2014-06-06 17:13 ` Jason Low
2014-06-06 18:12 ` Davidlohr Bueso
2014-06-06 18:48 ` Davidlohr Bueso
2014-06-06 19:08 ` Jason Low
2014-06-06 19:20 ` Davidlohr Bueso
2014-06-06 15:55 ` [PATCH 2/2] locking/rwsem: Disable optimistic spinning for PA-RISC Davidlohr Bueso
2014-06-06 16:09 ` James Bottomley
2014-06-06 17:11 ` Peter Zijlstra
2014-06-06 17:19 ` Chris Metcalf [this message]
2014-06-06 17:22 ` Linus Torvalds
2014-06-06 17:53 ` Peter Zijlstra
2014-06-06 17:57 ` James Bottomley
2014-06-06 17:58 ` James Bottomley
2014-06-06 18:01 ` Peter Zijlstra
2014-07-16 19:24 ` [tip:locking/urgent] locking/mutex: Disable optimistic spinning on some architectures tip-bot for Peter Zijlstra
2014-07-17 11:51 ` Christian Borntraeger
2014-07-17 11:58 ` Christian Borntraeger
2014-07-18 3:07 ` Davidlohr Bueso
2014-07-18 3:10 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391F83F.60005@tilera.com \
--to=cmetcalf@tilera.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aswin@hp.com \
--cc=dave.anglin@bell.net \
--cc=davem@davemloft.net \
--cc=davidlohr@hp.com \
--cc=james.hogan@imgtec.com \
--cc=jason.low2@hp.com \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpatocka@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vgupta@synopsys.com \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.