From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] apb: Fix compiler warnings (large constants)
Date: Sun, 08 Jun 2014 13:48:52 +0100 [thread overview]
Message-ID: <53945BB4.7030900@ilande.co.uk> (raw)
In-Reply-To: <1402167282-9264-1-git-send-email-sw@weilnetz.de>
On 07/06/14 19:54, Stefan Weil wrote:
> Both constants need more than 32 bit.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/pci-host/apb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
> index 1497008..6fa2723 100644
> --- a/hw/pci-host/apb.c
> +++ b/hw/pci-host/apb.c
> @@ -99,8 +99,8 @@ do { printf("IOMMU: " fmt , ## __VA_ARGS__); } while (0)
> #define IOMMU_TTE_DATA_SIZE (1ULL << 61)
> #define IOMMU_TTE_DATA_W (1ULL << 1)
>
> -#define IOMMU_TTE_PHYS_MASK_8K 0x1ffffffe000
> -#define IOMMU_TTE_PHYS_MASK_64K 0x1ffffff8000
> +#define IOMMU_TTE_PHYS_MASK_8K 0x1ffffffe000ULL
> +#define IOMMU_TTE_PHYS_MASK_64K 0x1ffffff8000ULL
>
> #define IOMMU_TSB_8K_OFFSET_MASK_8M 0x00000000007fe000ULL
> #define IOMMU_TSB_8K_OFFSET_MASK_16M 0x0000000000ffe000ULL
Gah yes, physical addresses in SPARC do lie outside the 32-bit range (I
guess this showed up building with a 32-bit compiler?). Is it urgent
enough to warrant me sending this as a separate pull request, or can it
simply be queued via trivial?
ATB,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] apb: Fix compiler warnings (large constants)
Date: Sun, 08 Jun 2014 13:48:52 +0100 [thread overview]
Message-ID: <53945BB4.7030900@ilande.co.uk> (raw)
In-Reply-To: <1402167282-9264-1-git-send-email-sw@weilnetz.de>
On 07/06/14 19:54, Stefan Weil wrote:
> Both constants need more than 32 bit.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/pci-host/apb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
> index 1497008..6fa2723 100644
> --- a/hw/pci-host/apb.c
> +++ b/hw/pci-host/apb.c
> @@ -99,8 +99,8 @@ do { printf("IOMMU: " fmt , ## __VA_ARGS__); } while (0)
> #define IOMMU_TTE_DATA_SIZE (1ULL << 61)
> #define IOMMU_TTE_DATA_W (1ULL << 1)
>
> -#define IOMMU_TTE_PHYS_MASK_8K 0x1ffffffe000
> -#define IOMMU_TTE_PHYS_MASK_64K 0x1ffffff8000
> +#define IOMMU_TTE_PHYS_MASK_8K 0x1ffffffe000ULL
> +#define IOMMU_TTE_PHYS_MASK_64K 0x1ffffff8000ULL
>
> #define IOMMU_TSB_8K_OFFSET_MASK_8M 0x00000000007fe000ULL
> #define IOMMU_TSB_8K_OFFSET_MASK_16M 0x0000000000ffe000ULL
Gah yes, physical addresses in SPARC do lie outside the 32-bit range (I
guess this showed up building with a 32-bit compiler?). Is it urgent
enough to warrant me sending this as a separate pull request, or can it
simply be queued via trivial?
ATB,
Mark.
next prev parent reply other threads:[~2014-06-08 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 18:54 [Qemu-trivial] [PATCH] apb: Fix compiler warnings (large constants) Stefan Weil
2014-06-07 18:54 ` [Qemu-devel] " Stefan Weil
2014-06-08 12:48 ` Mark Cave-Ayland [this message]
2014-06-08 12:48 ` Mark Cave-Ayland
2014-06-08 14:37 ` [Qemu-trivial] " Stefan Weil
2014-06-08 14:37 ` Stefan Weil
2014-06-08 13:13 ` [Qemu-trivial] " Michael Tokarev
2014-06-08 13:13 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53945BB4.7030900@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.