From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'
Date: Sun, 08 Jun 2014 12:34:01 -0700 [thread overview]
Message-ID: <5394BAA9.30609@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-ngVhdG5EemWziTcUbgKtwb+yDsFMTCKK0nk=wfKU_2w@mail.gmail.com>
On 06/08/2014 12:04 PM, Peter Maydell wrote:
> The other approach we could take would be to move these
> definitions from this .c file into a .h file (tcg-backend-helpers.h ?).
> Then clang won't complain (it seems to only warn about unused
> static-inline-functions in .c files, not in .h files).
>
> Richard: do you have a preference?
I don't like the idea of moving these to a public header, and I don't think
it's worthwhile creating a new private header. I'm ok with the unused attribute.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'
Date: Sun, 08 Jun 2014 12:34:01 -0700 [thread overview]
Message-ID: <5394BAA9.30609@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-ngVhdG5EemWziTcUbgKtwb+yDsFMTCKK0nk=wfKU_2w@mail.gmail.com>
On 06/08/2014 12:04 PM, Peter Maydell wrote:
> The other approach we could take would be to move these
> definitions from this .c file into a .h file (tcg-backend-helpers.h ?).
> Then clang won't complain (it seems to only warn about unused
> static-inline-functions in .c files, not in .h files).
>
> Richard: do you have a preference?
I don't like the idea of moving these to a public header, and I don't think
it's worthwhile creating a new private header. I'm ok with the unused attribute.
r~
next prev parent reply other threads:[~2014-06-08 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 17:08 [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused' Peter Maydell
2014-06-07 17:08 ` [Qemu-devel] " Peter Maydell
2014-06-08 12:11 ` [Qemu-trivial] " Michael Tokarev
2014-06-08 12:11 ` [Qemu-devel] " Michael Tokarev
2014-06-08 12:33 ` Peter Maydell
2014-06-08 12:33 ` [Qemu-devel] " Peter Maydell
2014-06-08 19:04 ` Peter Maydell
2014-06-08 19:04 ` [Qemu-devel] " Peter Maydell
2014-06-08 19:34 ` Richard Henderson [this message]
2014-06-08 19:34 ` Richard Henderson
2014-06-21 15:11 ` Michael Tokarev
2014-06-21 15:11 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5394BAA9.30609@twiddle.net \
--to=rth@twiddle.net \
--cc=mjt@tls.msk.ru \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.