From: Peter Lieven <pl@kamp.de>
To: Amit Shah <amit.shah@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: pbonzini@redhat.com, quintela@redhat.com, qemu-stable@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load
Date: Tue, 10 Jun 2014 10:04:43 +0200 [thread overview]
Message-ID: <5396BC1B.3020703@kamp.de> (raw)
In-Reply-To: <20140610073146.GJ27148@grmbl.mre>
On 10.06.2014 09:31, Amit Shah wrote:
> On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
>> * Peter Lieven (pl@kamp.de) wrote:
>>> if a saved vm has unknown flags in the memory data qemu
>>> currently simply ignores this flag and continues which
>>> yields in an unpredictable result.
>>>
>>> this patch catches all unknown flags and
>>> aborts the loading of the vm.
>> Yes, I think that's quite nice - the only thing I'd add which would help
>> a little is an error_report() in the case where you have invalid flags
>> to let you know that's the reason for the EINVAL.
>>
>> (Having spent the day tracking down migration bugs...)
> Peter, can you please add these before we pick the patch up?
On its way.
Peter
prev parent reply other threads:[~2014-06-10 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401485884-25500-1-git-send-email-pl@kamp.de>
2014-06-03 17:27 ` [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load Dr. David Alan Gilbert
2014-06-06 12:25 ` Amit Shah
2014-06-10 7:31 ` Amit Shah
2014-06-10 8:04 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5396BC1B.3020703@kamp.de \
--to=pl@kamp.de \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.