Re: [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property

[Paolo Bonzini <pbonzini@redhat.com>]

Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto:
> Up until now the virtio-blk x-data-plane and x-iothread features have been
> experimental.  It's time to commit to a final command-line interface:
>
>   qemu -object iothread,id=iothread0 \
>        -drive if=none,id=drive0,file=test.qcow2,format=qcow2 \
>        -device virtio-blk-pci,iothread=iothread0,drive=drive0
>
> The iothread=<iothread> property associates a virtio-blk-pci instance with an
> IOThread.  If the iothread property is not given, the non-dataplane code path
> is used.  This means dataplane is not the default yet.
>
> The x-data-plane=on|off property is now obsolete but will be kept around for at
> least another release cycle to give users a chance to migrate.
>
> Stefan Hajnoczi (3):
>   virtio-blk: replace x-iothread with iothread link property
>   qdev: drop iothread property type
>   virtio-blk: remove need for explicit x-data-plane=on option
>
>  hw/block/dataplane/virtio-blk.c  |  2 +-
>  hw/block/virtio-blk.c            | 12 +++++++++-
>  hw/core/qdev-properties-system.c | 50 ----------------------------------------
>  hw/s390x/s390-virtio-bus.c       |  2 ++
>  hw/s390x/virtio-ccw.c            |  2 ++
>  hw/virtio/virtio-pci.c           |  2 ++
>  include/hw/qdev-properties.h     |  3 ---
>  7 files changed, 18 insertions(+), 55 deletions(-)
>

I don't yet see object_property_add_alias, apart from that

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>