Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property

[Paolo Bonzini <pbonzini@redhat.com>]

Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto:
> @@ -193,6 +193,8 @@ static void s390_virtio_blk_instance_init(Object *obj)
>      object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL);
>      object_unref(OBJECT(&dev->vdev));
>      qdev_alias_all_properties(DEVICE(&dev->vdev), obj);
> +    object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread",
> +                              &error_abort);

Actually this won't work.  Link properties have to have a LinkProperty 
opaque.

The series I posted to add a "resolve" callback for properties can be 
used here, fixing object_property_add_alias to add a "resolve" callback 
to the newly-created property.

My ack for this patch still stands, it's just a matter of patch ordering.

Paolo