All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <trblinux@gmail.com>
To: Kevin Hilman <khilman@linaro.org>
Cc: Doug Anderson <dianders@google.com>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Shaik Ameer Basha <shaik.samsung@gmail.com>,
	Olof Johansson <olof@lixom.net>,
	"Turquette, Mike" <mturquette@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?
Date: Wed, 11 Jun 2014 11:09:37 +0530	[thread overview]
Message-ID: <5397EB99.1070209@gmail.com> (raw)
In-Reply-To: <CAD=FV=UdCp0dG7tnzaSnWxhtnU46ttMOUht00DL=bfvbbt7mXQ@mail.gmail.com>

On 06/11/2014 01:56 AM, Doug Anderson wrote:
> Javier,
> 
> On Tue, Jun 10, 2014 at 1:03 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> Yes, I did not have this issue before. However... I installed the latest Peach
>> pit recovery image you provided me and mainline kernel started to hang on boot.
>> I remembered this thread so tested Kevin's patch which make it boot again.
>>
>> You said that chain-booting u-boot runs the sound init code but did you try
>> booting a signed FIT image using the verified u-boot?
> 
> Right, I'd bet that it's actually verified boot that's calling the
> sound init code (probably just in case it needs to beep at the user).
> ...so this would happen even without chain booting.  I haven't tried
> signing / booting without chain booting, but I can totally believe it
> would hang just as easily.
> 
> 
>> I'm asking because I'm see the hang both when chain-booting nv-u-boot from a
>> kernel partition and booting a signed FIT image with the verified u-boot.
>>
>> So it seems this is a regression in latest U-boot and I didn't run into this
>> before due having an older RW U-Boot on my Peach pit?
> 
> You must have had a very old RW U-Boot, possibly one before audio
> support was added.  I think we just need to fix this in the kernel so
> it doesn't hang.
> 
> -Doug
> 

Hi Kevin,

I have posted the fixes[1] in the mailing list. Please test and update.

Changes:
1 patch in drivers/clk/samsung/clk-exynos-audss.c
1 patch in arch/arm/boot/dts/exynos5420.dtsi

For testing audio in Peach-pi,
1 patch in arch/arm/boot/dts/exynos5800-peach-pi.dts

[1] [PATCH 0/3] Fix boot-hang on Peach-pit and Enable audio

-- 
Tushar Behera

WARNING: multiple messages have this Message-ID (diff)
From: trblinux@gmail.com (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?
Date: Wed, 11 Jun 2014 11:09:37 +0530	[thread overview]
Message-ID: <5397EB99.1070209@gmail.com> (raw)
In-Reply-To: <CAD=FV=UdCp0dG7tnzaSnWxhtnU46ttMOUht00DL=bfvbbt7mXQ@mail.gmail.com>

On 06/11/2014 01:56 AM, Doug Anderson wrote:
> Javier,
> 
> On Tue, Jun 10, 2014 at 1:03 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> Yes, I did not have this issue before. However... I installed the latest Peach
>> pit recovery image you provided me and mainline kernel started to hang on boot.
>> I remembered this thread so tested Kevin's patch which make it boot again.
>>
>> You said that chain-booting u-boot runs the sound init code but did you try
>> booting a signed FIT image using the verified u-boot?
> 
> Right, I'd bet that it's actually verified boot that's calling the
> sound init code (probably just in case it needs to beep at the user).
> ...so this would happen even without chain booting.  I haven't tried
> signing / booting without chain booting, but I can totally believe it
> would hang just as easily.
> 
> 
>> I'm asking because I'm see the hang both when chain-booting nv-u-boot from a
>> kernel partition and booting a signed FIT image with the verified u-boot.
>>
>> So it seems this is a regression in latest U-boot and I didn't run into this
>> before due having an older RW U-Boot on my Peach pit?
> 
> You must have had a very old RW U-Boot, possibly one before audio
> support was added.  I think we just need to fix this in the kernel so
> it doesn't hang.
> 
> -Doug
> 

Hi Kevin,

I have posted the fixes[1] in the mailing list. Please test and update.

Changes:
1 patch in drivers/clk/samsung/clk-exynos-audss.c
1 patch in arch/arm/boot/dts/exynos5420.dtsi

For testing audio in Peach-pi,
1 patch in arch/arm/boot/dts/exynos5800-peach-pi.dts

[1] [PATCH 0/3] Fix boot-hang on Peach-pit and Enable audio

-- 
Tushar Behera

  reply	other threads:[~2014-06-11  5:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  0:15 exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled? Kevin Hilman
2014-06-06  0:15 ` Kevin Hilman
2014-06-09 21:51 ` Kevin Hilman
2014-06-09 21:51   ` Kevin Hilman
2014-06-10  6:48   ` Shaik Ameer Basha
2014-06-10  6:48     ` Shaik Ameer Basha
2014-06-10 17:39     ` Doug Anderson
2014-06-10 17:39       ` Doug Anderson
2014-06-10 20:03       ` Javier Martinez Canillas
2014-06-10 20:03         ` Javier Martinez Canillas
2014-06-10 20:26         ` Doug Anderson
2014-06-10 20:26           ` Doug Anderson
2014-06-11  5:39           ` Tushar Behera [this message]
2014-06-11  5:39             ` Tushar Behera
2014-06-11 15:56             ` Javier Martinez Canillas
2014-06-11 15:56               ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5397EB99.1070209@gmail.com \
    --to=trblinux@gmail.com \
    --cc=dianders@google.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=olof@lixom.net \
    --cc=shaik.samsung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.