All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Bo Shen <voice.shen@atmel.com>, broonie@kernel.org
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ASoC: atmel-ssc: distinguish whether SSC supports fslen ext
Date: Wed, 11 Jun 2014 12:25:04 +0200	[thread overview]
Message-ID: <53982E80.5070908@atmel.com> (raw)
In-Reply-To: <1402481682-9811-2-git-send-email-voice.shen@atmel.com>

On 11/06/2014 12:14, Bo Shen :
> Add compatible string to distinguish whether SSC supports
> frame sync length extension.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

Ok, I am fine with this one:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
> Changes in v2:
>   - Using compatible string to distinguish whether SSC supports
>     frame sync length extension to replace check IP version.
> 
>  drivers/misc/atmel-ssc.c  | 13 +++++++++++++
>  include/linux/atmel-ssc.h |  1 +
>  2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 22de137..60843a2 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -83,10 +83,17 @@ EXPORT_SYMBOL(ssc_free);
>  
>  static struct atmel_ssc_platform_data at91rm9200_config = {
>  	.use_dma = 0,
> +	.has_fslen_ext = 0,
> +};
> +
> +static struct atmel_ssc_platform_data at91sam9rl_config = {
> +	.use_dma = 0,
> +	.has_fslen_ext = 1,
>  };
>  
>  static struct atmel_ssc_platform_data at91sam9g45_config = {
>  	.use_dma = 1,
> +	.has_fslen_ext = 1,
>  };
>  
>  static const struct platform_device_id atmel_ssc_devtypes[] = {
> @@ -94,6 +101,9 @@ static const struct platform_device_id atmel_ssc_devtypes[] = {
>  		.name = "at91rm9200_ssc",
>  		.driver_data = (unsigned long) &at91rm9200_config,
>  	}, {
> +		.name = "at91sam9rl_ssc",
> +		.driver_data = (unsigned long) &at91sam9rl_config,
> +	}, {
>  		.name = "at91sam9g45_ssc",
>  		.driver_data = (unsigned long) &at91sam9g45_config,
>  	}, {
> @@ -107,6 +117,9 @@ static const struct of_device_id atmel_ssc_dt_ids[] = {
>  		.compatible = "atmel,at91rm9200-ssc",
>  		.data = &at91rm9200_config,
>  	}, {
> +		.compatible = "atmel,at91sam9rl-ssc",
> +		.data = &at91sam9rl_config,
> +	}, {
>  		.compatible = "atmel,at91sam9g45-ssc",
>  		.data = &at91sam9g45_config,
>  	}, {
> diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
> index 571a12e..e8dd408 100644
> --- a/include/linux/atmel-ssc.h
> +++ b/include/linux/atmel-ssc.h
> @@ -7,6 +7,7 @@
>  
>  struct atmel_ssc_platform_data {
>  	int			use_dma;
> +	int			has_fslen_ext;
>  };
>  
>  struct ssc_device {
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Bo Shen <voice.shen@atmel.com>, broonie@kernel.org
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ASoC: atmel-ssc: distinguish whether SSC supports fslen ext
Date: Wed, 11 Jun 2014 10:25:04 +0000	[thread overview]
Message-ID: <53982E80.5070908@atmel.com> (raw)
In-Reply-To: <1402481682-9811-2-git-send-email-voice.shen@atmel.com>

On 11/06/2014 12:14, Bo Shen :
> Add compatible string to distinguish whether SSC supports
> frame sync length extension.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

Ok, I am fine with this one:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
> Changes in v2:
>   - Using compatible string to distinguish whether SSC supports
>     frame sync length extension to replace check IP version.
> 
>  drivers/misc/atmel-ssc.c  | 13 +++++++++++++
>  include/linux/atmel-ssc.h |  1 +
>  2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 22de137..60843a2 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -83,10 +83,17 @@ EXPORT_SYMBOL(ssc_free);
>  
>  static struct atmel_ssc_platform_data at91rm9200_config = {
>  	.use_dma = 0,
> +	.has_fslen_ext = 0,
> +};
> +
> +static struct atmel_ssc_platform_data at91sam9rl_config = {
> +	.use_dma = 0,
> +	.has_fslen_ext = 1,
>  };
>  
>  static struct atmel_ssc_platform_data at91sam9g45_config = {
>  	.use_dma = 1,
> +	.has_fslen_ext = 1,
>  };
>  
>  static const struct platform_device_id atmel_ssc_devtypes[] = {
> @@ -94,6 +101,9 @@ static const struct platform_device_id atmel_ssc_devtypes[] = {
>  		.name = "at91rm9200_ssc",
>  		.driver_data = (unsigned long) &at91rm9200_config,
>  	}, {
> +		.name = "at91sam9rl_ssc",
> +		.driver_data = (unsigned long) &at91sam9rl_config,
> +	}, {
>  		.name = "at91sam9g45_ssc",
>  		.driver_data = (unsigned long) &at91sam9g45_config,
>  	}, {
> @@ -107,6 +117,9 @@ static const struct of_device_id atmel_ssc_dt_ids[] = {
>  		.compatible = "atmel,at91rm9200-ssc",
>  		.data = &at91rm9200_config,
>  	}, {
> +		.compatible = "atmel,at91sam9rl-ssc",
> +		.data = &at91sam9rl_config,
> +	}, {
>  		.compatible = "atmel,at91sam9g45-ssc",
>  		.data = &at91sam9g45_config,
>  	}, {
> diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
> index 571a12e..e8dd408 100644
> --- a/include/linux/atmel-ssc.h
> +++ b/include/linux/atmel-ssc.h
> @@ -7,6 +7,7 @@
>  
>  struct atmel_ssc_platform_data {
>  	int			use_dma;
> +	int			has_fslen_ext;
>  };
>  
>  struct ssc_device {
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] ASoC: atmel-ssc: distinguish whether SSC supports fslen ext
Date: Wed, 11 Jun 2014 12:25:04 +0200	[thread overview]
Message-ID: <53982E80.5070908@atmel.com> (raw)
In-Reply-To: <1402481682-9811-2-git-send-email-voice.shen@atmel.com>

On 11/06/2014 12:14, Bo Shen :
> Add compatible string to distinguish whether SSC supports
> frame sync length extension.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

Ok, I am fine with this one:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
> Changes in v2:
>   - Using compatible string to distinguish whether SSC supports
>     frame sync length extension to replace check IP version.
> 
>  drivers/misc/atmel-ssc.c  | 13 +++++++++++++
>  include/linux/atmel-ssc.h |  1 +
>  2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 22de137..60843a2 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -83,10 +83,17 @@ EXPORT_SYMBOL(ssc_free);
>  
>  static struct atmel_ssc_platform_data at91rm9200_config = {
>  	.use_dma = 0,
> +	.has_fslen_ext = 0,
> +};
> +
> +static struct atmel_ssc_platform_data at91sam9rl_config = {
> +	.use_dma = 0,
> +	.has_fslen_ext = 1,
>  };
>  
>  static struct atmel_ssc_platform_data at91sam9g45_config = {
>  	.use_dma = 1,
> +	.has_fslen_ext = 1,
>  };
>  
>  static const struct platform_device_id atmel_ssc_devtypes[] = {
> @@ -94,6 +101,9 @@ static const struct platform_device_id atmel_ssc_devtypes[] = {
>  		.name = "at91rm9200_ssc",
>  		.driver_data = (unsigned long) &at91rm9200_config,
>  	}, {
> +		.name = "at91sam9rl_ssc",
> +		.driver_data = (unsigned long) &at91sam9rl_config,
> +	}, {
>  		.name = "at91sam9g45_ssc",
>  		.driver_data = (unsigned long) &at91sam9g45_config,
>  	}, {
> @@ -107,6 +117,9 @@ static const struct of_device_id atmel_ssc_dt_ids[] = {
>  		.compatible = "atmel,at91rm9200-ssc",
>  		.data = &at91rm9200_config,
>  	}, {
> +		.compatible = "atmel,at91sam9rl-ssc",
> +		.data = &at91sam9rl_config,
> +	}, {
>  		.compatible = "atmel,at91sam9g45-ssc",
>  		.data = &at91sam9g45_config,
>  	}, {
> diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
> index 571a12e..e8dd408 100644
> --- a/include/linux/atmel-ssc.h
> +++ b/include/linux/atmel-ssc.h
> @@ -7,6 +7,7 @@
>  
>  struct atmel_ssc_platform_data {
>  	int			use_dma;
> +	int			has_fslen_ext;
>  };
>  
>  struct ssc_device {
> 


-- 
Nicolas Ferre

  reply	other threads:[~2014-06-11 10:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 10:14 [PATCH v2 0/4] ASoC: atmel_ssc: enable fslen extension feature Bo Shen
2014-06-11 10:14 ` Bo Shen
2014-06-11 10:14 ` Bo Shen
2014-06-11 10:14 ` [PATCH v2 1/4] ASoC: atmel-ssc: distinguish whether SSC supports fslen ext Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-06-11 10:25   ` Nicolas Ferre [this message]
2014-06-11 10:25     ` Nicolas Ferre
2014-06-11 10:25     ` Nicolas Ferre
2014-06-21 10:37   ` Mark Brown
2014-06-21 10:37     ` Mark Brown
2014-06-21 10:37     ` Mark Brown
2014-06-11 10:14 ` [PATCH v2 2/4] ASoC: atmel_ssc_dai: enable fslen extension feature Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-06-21 10:37   ` Mark Brown
2014-06-21 10:37     ` Mark Brown
2014-06-21 10:37     ` Mark Brown
2014-06-11 10:14 ` [PATCH v2 3/4] dts: atmel: at91sam9rl: switch ssc compatible string Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-09-02  9:15   ` Nicolas Ferre
2014-09-02  9:15     ` Nicolas Ferre
2014-09-02  9:15     ` Nicolas Ferre
2014-06-11 10:14 ` [PATCH v2 4/4] dts: atmel: at91sam9g20: " Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-06-11 10:14   ` Bo Shen
2014-09-02  9:14   ` Nicolas Ferre
2014-09-02  9:14     ` Nicolas Ferre
2014-09-02  9:14     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53982E80.5070908@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=voice.shen@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.