* [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update
@ 2014-06-04 11:42 Qiao Zhou
2014-06-12 6:52 ` Qiao Zhou
2014-06-21 10:30 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Qiao Zhou @ 2014-06-04 11:42 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, alsa-devel; +Cc: Qiao Zhou
we need to release dapm widget list after dpcm_path_get in
soc_dpcm_runtime_update. otherwise, there will be potential memory
leak. add dpcm_path_put to fix it.
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
sound/soc/soc-pcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index a391de0..3bb8b80 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -2072,6 +2072,7 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card)
dpcm_be_disconnect(fe, SNDRV_PCM_STREAM_PLAYBACK);
}
+ dpcm_path_put(&list);
capture:
/* skip if FE doesn't have capture capability */
if (!fe->cpu_dai->driver->capture.channels_min)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update
2014-06-04 11:42 [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update Qiao Zhou
@ 2014-06-12 6:52 ` Qiao Zhou
2014-06-21 10:30 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Qiao Zhou @ 2014-06-12 6:52 UTC (permalink / raw)
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.de, zhangfei.gao@gmail.com
Cc: alsa-devel@alsa-project.org
On 06/04/2014 07:42 PM, Qiao Zhou wrote:
> we need to release dapm widget list after dpcm_path_get in
> soc_dpcm_runtime_update. otherwise, there will be potential memory
> leak. add dpcm_path_put to fix it.
>
> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
> ---
> sound/soc/soc-pcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index a391de0..3bb8b80 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -2072,6 +2072,7 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card)
> dpcm_be_disconnect(fe, SNDRV_PCM_STREAM_PLAYBACK);
> }
>
> + dpcm_path_put(&list);
> capture:
> /* skip if FE doesn't have capture capability */
> if (!fe->cpu_dai->driver->capture.channels_min)
>
Hi Maintainers,
Do you have any comments? Thanks.
--
Best Regards
Qiao
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update
2014-06-04 11:42 [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update Qiao Zhou
2014-06-12 6:52 ` Qiao Zhou
@ 2014-06-21 10:30 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-06-21 10:30 UTC (permalink / raw)
To: Qiao Zhou; +Cc: tiwai, alsa-devel, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 244 bytes --]
On Wed, Jun 04, 2014 at 07:42:06PM +0800, Qiao Zhou wrote:
> we need to release dapm widget list after dpcm_path_get in
> soc_dpcm_runtime_update. otherwise, there will be potential memory
> leak. add dpcm_path_put to fix it.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-21 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-04 11:42 [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update Qiao Zhou
2014-06-12 6:52 ` Qiao Zhou
2014-06-21 10:30 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.