From: Sricharan R <r.sricharan@ti.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
tony@atomide.com, santosh.shilimkar@ti.com, nm@ti.com,
rnayak@ti.com, linux@arm.linux.org.uk, tglx@linutronix.de
Subject: Re: [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning
Date: Thu, 12 Jun 2014 19:09:31 +0530 [thread overview]
Message-ID: <5399AD93.40601@ti.com> (raw)
In-Reply-To: <20140612131434.GV8664@titan.lakedaemon.net>
Hi Jason,
On Thursday 12 June 2014 06:44 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> kernel doc style is wrong in code. fix it to squelch
>> kerneldoc warnings:
>
> I would re-word the above to mention that we need to add missing
> properties for kerneldoc (@write, @safemap), and we're doing some
> cleanup of harmless warnings while we are here.
>
Ok, will do this.
>> Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description on line:
>> * struct crossbar_device: crossbar device description
>> Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
>> Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter 'write'
>> Warning(drivers/irqchip/irq-crossbar.c:42): missing initial short description on line:
>> * struct crossbar_data: Platform specific data
>> Info(drivers/irqchip/irq-crossbar.c:42): Scanning doc for struct
>> Warning(drivers/irqchip/irq-crossbar.c:50): No description found for parameter 'safe_map'
>> 4 warnings
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> drivers/irqchip/irq-crossbar.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
>> index 58790d4..7d4db07 100644
>> --- a/drivers/irqchip/irq-crossbar.c
>> +++ b/drivers/irqchip/irq-crossbar.c
>> @@ -23,11 +23,13 @@
>> #define IRQ_SKIP -3
>> #define GIC_IRQ_START 32
>>
>> -/*
>> +/**
>> + * struct crossbar_device - crossbar device descriptio
>
> s/descriptio/description/
Ok, will correct.
Regards,
Sricharan
WARNING: multiple messages have this Message-ID (diff)
From: r.sricharan@ti.com (Sricharan R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning
Date: Thu, 12 Jun 2014 19:09:31 +0530 [thread overview]
Message-ID: <5399AD93.40601@ti.com> (raw)
In-Reply-To: <20140612131434.GV8664@titan.lakedaemon.net>
Hi Jason,
On Thursday 12 June 2014 06:44 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> kernel doc style is wrong in code. fix it to squelch
>> kerneldoc warnings:
>
> I would re-word the above to mention that we need to add missing
> properties for kerneldoc (@write, @safemap), and we're doing some
> cleanup of harmless warnings while we are here.
>
Ok, will do this.
>> Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description on line:
>> * struct crossbar_device: crossbar device description
>> Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
>> Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter 'write'
>> Warning(drivers/irqchip/irq-crossbar.c:42): missing initial short description on line:
>> * struct crossbar_data: Platform specific data
>> Info(drivers/irqchip/irq-crossbar.c:42): Scanning doc for struct
>> Warning(drivers/irqchip/irq-crossbar.c:50): No description found for parameter 'safe_map'
>> 4 warnings
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> drivers/irqchip/irq-crossbar.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
>> index 58790d4..7d4db07 100644
>> --- a/drivers/irqchip/irq-crossbar.c
>> +++ b/drivers/irqchip/irq-crossbar.c
>> @@ -23,11 +23,13 @@
>> #define IRQ_SKIP -3
>> #define GIC_IRQ_START 32
>>
>> -/*
>> +/**
>> + * struct crossbar_device - crossbar device descriptio
>
> s/descriptio/description/
Ok, will correct.
Regards,
Sricharan
WARNING: multiple messages have this Message-ID (diff)
From: Sricharan R <r.sricharan@ti.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<tony@atomide.com>, <santosh.shilimkar@ti.com>, <nm@ti.com>,
<rnayak@ti.com>, <linux@arm.linux.org.uk>, <tglx@linutronix.de>
Subject: Re: [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning
Date: Thu, 12 Jun 2014 19:09:31 +0530 [thread overview]
Message-ID: <5399AD93.40601@ti.com> (raw)
In-Reply-To: <20140612131434.GV8664@titan.lakedaemon.net>
Hi Jason,
On Thursday 12 June 2014 06:44 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> kernel doc style is wrong in code. fix it to squelch
>> kerneldoc warnings:
>
> I would re-word the above to mention that we need to add missing
> properties for kerneldoc (@write, @safemap), and we're doing some
> cleanup of harmless warnings while we are here.
>
Ok, will do this.
>> Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description on line:
>> * struct crossbar_device: crossbar device description
>> Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
>> Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter 'write'
>> Warning(drivers/irqchip/irq-crossbar.c:42): missing initial short description on line:
>> * struct crossbar_data: Platform specific data
>> Info(drivers/irqchip/irq-crossbar.c:42): Scanning doc for struct
>> Warning(drivers/irqchip/irq-crossbar.c:50): No description found for parameter 'safe_map'
>> 4 warnings
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> drivers/irqchip/irq-crossbar.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
>> index 58790d4..7d4db07 100644
>> --- a/drivers/irqchip/irq-crossbar.c
>> +++ b/drivers/irqchip/irq-crossbar.c
>> @@ -23,11 +23,13 @@
>> #define IRQ_SKIP -3
>> #define GIC_IRQ_START 32
>>
>> -/*
>> +/**
>> + * struct crossbar_device - crossbar device descriptio
>
> s/descriptio/description/
Ok, will correct.
Regards,
Sricharan
next prev parent reply other threads:[~2014-06-12 13:39 UTC|newest]
Thread overview: 175+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 11:53 [PATCH V2 00/19] irqchip: crossbar: driver fixes Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 12:51 ` Jason Cooper
2014-06-12 12:51 ` Jason Cooper
[not found] ` <20140612125134.GS8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-12 13:19 ` Sricharan R
2014-06-12 13:19 ` Sricharan R
2014-06-12 13:19 ` Sricharan R
[not found] ` <5399A8D5.6070105-l0cyMroinI0@public.gmane.org>
2014-06-12 14:07 ` Jason Cooper
2014-06-12 14:07 ` Jason Cooper
2014-06-12 14:07 ` Jason Cooper
[not found] ` <20140612140729.GD8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-13 6:37 ` Sricharan R
2014-06-13 6:37 ` Sricharan R
2014-06-13 6:37 ` Sricharan R
2014-06-13 13:34 ` Jason Cooper
2014-06-13 13:34 ` Jason Cooper
2014-06-12 13:57 ` Tony Lindgren
2014-06-12 13:57 ` Tony Lindgren
2014-06-12 14:05 ` Jason Cooper
2014-06-12 14:05 ` Jason Cooper
2014-06-13 6:56 ` Sricharan R
2014-06-13 6:56 ` Sricharan R
2014-06-13 6:56 ` Sricharan R
[not found] ` <539AA08A.7010001-l0cyMroinI0@public.gmane.org>
2014-06-13 11:04 ` Sricharan R
2014-06-13 11:04 ` Sricharan R
2014-06-13 11:04 ` Sricharan R
2014-06-13 13:10 ` Jason Cooper
2014-06-13 13:10 ` Jason Cooper
[not found] ` <20140613131005.GF8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-13 13:35 ` Santosh Shilimkar
2014-06-13 13:35 ` Santosh Shilimkar
2014-06-13 13:35 ` Santosh Shilimkar
2014-06-13 13:41 ` Jason Cooper
2014-06-13 13:41 ` Jason Cooper
2014-06-13 6:31 ` Sricharan R
2014-06-13 6:31 ` Sricharan R
2014-06-13 6:31 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-6-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 12:56 ` Jason Cooper
2014-06-12 12:56 ` Jason Cooper
2014-06-12 12:56 ` Jason Cooper
2014-06-13 6:09 ` Sricharan R
2014-06-13 6:09 ` Sricharan R
2014-06-13 6:09 ` Sricharan R
[not found] ` <539A95A3.1010301-l0cyMroinI0@public.gmane.org>
2014-06-13 13:13 ` Jason Cooper
2014-06-13 13:13 ` Jason Cooper
2014-06-13 13:13 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-9-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:10 ` Jason Cooper
2014-06-12 13:10 ` Jason Cooper
2014-06-12 13:10 ` Jason Cooper
[not found] ` <20140612131042.GU8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-12 13:35 ` Sricharan R
2014-06-12 13:35 ` Sricharan R
2014-06-12 13:35 ` Sricharan R
[not found] ` <5399AC9C.4080602-l0cyMroinI0@public.gmane.org>
2014-06-12 14:18 ` Joe Perches
2014-06-12 14:18 ` Joe Perches
2014-06-12 14:18 ` Joe Perches
2014-06-12 15:32 ` Jason Cooper
2014-06-12 15:32 ` Jason Cooper
[not found] ` <20140612153226.GE8664-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-06-12 16:05 ` Joe Perches
2014-06-12 16:05 ` Joe Perches
2014-06-12 16:05 ` Joe Perches
2014-06-13 6:30 ` Sricharan R
2014-06-13 6:30 ` Sricharan R
2014-06-13 6:30 ` Sricharan R
[not found] ` <539A9A87.6020004-l0cyMroinI0@public.gmane.org>
2014-06-13 13:15 ` Jason Cooper
2014-06-13 13:15 ` Jason Cooper
2014-06-13 13:15 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-10-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:14 ` Jason Cooper
2014-06-12 13:14 ` Jason Cooper
2014-06-12 13:14 ` Jason Cooper
2014-06-12 13:39 ` Sricharan R [this message]
2014-06-12 13:39 ` Sricharan R
2014-06-12 13:39 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-11-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:16 ` Jason Cooper
2014-06-12 13:16 ` Jason Cooper
2014-06-12 13:16 ` Jason Cooper
2014-06-12 13:21 ` Sricharan R
2014-06-12 13:21 ` Sricharan R
2014-06-12 13:21 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-12-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:20 ` Jason Cooper
2014-06-12 13:20 ` Jason Cooper
2014-06-12 13:20 ` Jason Cooper
2014-06-12 13:37 ` Sricharan R
2014-06-12 13:37 ` Sricharan R
2014-06-12 13:37 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 12/19] irqchip: crossbar: return proper error value Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 13:39 ` Jason Cooper
2014-06-12 13:39 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 13/19] irqchip: crossbar: change the goto naming Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-14-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:41 ` Jason Cooper
2014-06-12 13:41 ` Jason Cooper
2014-06-12 13:41 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 13:49 ` Jason Cooper
2014-06-12 13:49 ` Jason Cooper
2014-06-12 13:50 ` Sricharan R
2014-06-12 13:50 ` Sricharan R
2014-06-12 13:50 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti, max-crossbar-sources " Sricharan R
[not found] ` <1402574007-13987-17-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-12 13:54 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources " Jason Cooper
2014-06-12 13:54 ` Jason Cooper
2014-06-12 13:54 ` Jason Cooper
2014-06-13 10:54 ` Sricharan R
2014-06-13 10:54 ` Sricharan R
2014-06-13 10:54 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti, max-crossbar-sources " Sricharan R
2014-06-13 13:17 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources " Jason Cooper
2014-06-13 13:17 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
[not found] ` <1402574007-13987-1-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2014-06-13 15:01 ` [PATCH V2 00/19] irqchip: crossbar: driver fixes Jason Cooper
2014-06-13 15:01 ` Jason Cooper
2014-06-13 15:01 ` Jason Cooper
2014-06-13 16:14 ` Joe Perches
2014-06-13 16:14 ` Joe Perches
2014-06-13 16:37 ` Jason Cooper
2014-06-13 16:37 ` Jason Cooper
2014-06-13 16:37 ` Jason Cooper
2014-06-13 16:48 ` Joe Perches
2014-06-13 16:48 ` Joe Perches
2014-06-13 16:54 ` Jason Cooper
2014-06-13 16:54 ` Jason Cooper
2014-06-13 20:38 ` Thomas Gleixner
2014-06-13 20:38 ` Thomas Gleixner
2014-06-13 22:22 ` Joe Perches
2014-06-13 22:22 ` Joe Perches
2014-06-13 22:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399AD93.40601@ti.com \
--to=r.sricharan@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.