All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	<viro@ZenIV.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH pre 3.16-rc1] bio: Fix build failure.
Date: Fri, 13 Jun 2014 10:34:59 -0400	[thread overview]
Message-ID: <539B0C13.8040306@fb.com> (raw)
In-Reply-To: <201406132103.HCI73982.HFOOMFFSLVtJQO@I-love.SAKURA.ne.jp>

On 06/13/2014 08:03 AM, Tetsuo Handa wrote:
>>From 75b9f78ddc8ab30555a520f5a2477a9340341dd1 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Fri, 13 Jun 2014 12:35:35 +0900
> Subject: [PATCH pre 3.16-rc1] bio: Fix build failure.
> 
> Commit 62a8067a7f "bio_vec-backed iov_iter" introduced an unnamed union
> inside a struct which gcc-4.4.7 cannot handle. Name the unnamed union as
> u in order to fix build failure.

Same problem here.  Jens tracked it down to the anon union and the named
initialization done in page_io.c

> diff --git a/mm/page_io.c b/mm/page_io.c
> index 243a9b7..875a460 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -274,7 +274,7 @@ int __swap_writepage(struct page *page, struct writeback_control *wbc,
>  			.count = PAGE_SIZE,
>  			.iov_offset = 0,
>  			.nr_segs = 1,
> -			.bvec = &bv
> +			.u.bvec = &bv
>  		};
>  
>  		init_sync_kiocb(&kiocb, swap_file);
> 


-chris

  reply	other threads:[~2014-06-13 14:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 12:03 [PATCH pre 3.16-rc1] bio: Fix build failure Tetsuo Handa
2014-06-13 14:34 ` Chris Mason [this message]
2014-06-13 14:48 ` Al Viro
2014-06-14  6:12   ` [PATCH] fix __swap_writepage() compile failure on old gcc versions Al Viro
2014-06-15  1:33     ` Tetsuo Handa
2014-06-16 17:55     ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539B0C13.8040306@fb.com \
    --to=clm@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.