From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Dushyant Behl <myselfdushyantbehl@gmail.com>
Cc: Andres Lagar Cavilla <andres.lagarcavilla@gmail.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
dave.scott@eu.citrix.com, Ian Campbell <Ian.Campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc.
Date: Fri, 13 Jun 2014 16:06:15 +0100 [thread overview]
Message-ID: <539B1367.6000304@citrix.com> (raw)
In-Reply-To: <CAHF350+2AuYAWv49RBsOB8zVW6waJm=uwfYwbxuSNNoeLyMquQ@mail.gmail.com>
On 13/06/14 16:00, Dushyant Behl wrote:
>>> -CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenstore) $(PTHREAD_CFLAGS)
>>> -LDLIBS += $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) $(PTHREAD_LIBS)
>>> +CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) $(PTHREAD_CFLAGS)
>>> +LDLIBS += $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) $(PTHREAD_LIBS)
>> You are not introducing any libxenstore calls into xenpaging. This
>> change is bogus.
> Sorry but, I have only introduced libxenguest flags and libs, because
> the file xc_mem_paging_ring_setup.c which I have created is compiled
> into libxenguest, hence the dependency.
> libxenstore on the other hand was already present here because
> xenpaging.c has a used a lot of libxenstore calls.
Oh sorry - my mistake. I misread that as an introduction of
libxenstore, whereas it is actually an insertion of libxenguest into the
middle.
That's fine then.
~Andrew
next prev parent reply other threads:[~2014-06-13 15:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 9:23 [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc Dushyant Behl
2014-06-12 9:42 ` Dave Scott
2014-06-12 13:22 ` Andrew Cooper
2014-06-12 13:27 ` Ian Campbell
2014-06-12 13:29 ` Andrew Cooper
2014-06-12 13:49 ` Andres Lagar Cavilla
2014-06-12 13:55 ` Ian Campbell
2014-06-12 14:01 ` Andres Lagar Cavilla
2014-06-12 13:59 ` Andres Lagar Cavilla
2014-06-12 14:03 ` Dushyant Behl
2014-06-12 14:11 ` Andrew Cooper
2014-06-12 14:21 ` Ian Campbell
2014-06-12 14:46 ` Andrew Cooper
2014-06-13 14:16 ` Dushyant Behl
2014-06-13 14:23 ` Dushyant Behl
2014-06-13 14:37 ` Andrew Cooper
2014-06-13 15:03 ` Andres Lagar Cavilla
2014-06-13 14:51 ` Andrew Cooper
2014-06-13 15:00 ` Dushyant Behl
2014-06-13 15:06 ` Andrew Cooper [this message]
2014-06-13 15:07 ` Andres Lagar Cavilla
2014-06-13 15:55 ` Andrew Cooper
2014-06-13 16:09 ` Andres Lagar Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539B1367.6000304@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=andres.lagarcavilla@gmail.com \
--cc=dave.scott@eu.citrix.com \
--cc=myselfdushyantbehl@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.