From: Stefan Weil <sw@weilnetz.de>
To: Lb peace <peaceustc@gmail.com>, qemu-devel@nongnu.org
Cc: afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH]Fix two functions of the same name
Date: Fri, 13 Jun 2014 19:05:28 +0200 [thread overview]
Message-ID: <539B2F58.50400@weilnetz.de> (raw)
In-Reply-To: <CANycmrrGm0N50_0xo91iPkdMirpeWiyXKw97wQaL0sTX7-m=Cg@mail.gmail.com>
Am 13.06.2014 13:49, schrieb Lb peace:
> It is funny that we have two sigbus_handler in our QEMU.(exec.c &
> cpus.c)Change one's name.
>
> Signed-off-by: Peace <peacelb@gmail.com)>
> ---
> cpus.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Technically it does not matter whether two functions have the same name
as long as both are in different compilation units (*.c files) and have
only a local scope (that's what the 'static' keyword does).
There are even function names in QEMU code which occur three or more
times. Look for register_types, for example.
They do you think this should be changed? The only reason I see is that
setting breakpoints while debugging is a little bit more difficult.
Regards
Stefan
prev parent reply other threads:[~2014-06-13 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 11:49 [Qemu-devel] [PATCH]Fix two functions of the same name Lb peace
2014-06-13 17:05 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539B2F58.50400@weilnetz.de \
--to=sw@weilnetz.de \
--cc=afaerber@suse.de \
--cc=peaceustc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.