Re: [Printing-architecture] "no-color-management" not a good idea for a name of a boolean CUPS option

[Till Kamppeter <till.kamppeter@gmail.com>]

On 06/13/2014 01:52 AM, Joseph Simon wrote:
> Hi everyone,
> 
> Rev. 7225 of 'cups-filters' now replaces "no-color-management" with
> "cm-calibration" for the bool option. So the following commands should
> work without the added '=' symbol, and will disable ICC profile management:
> 
> $ rastertopdf 1 foo bar 1 "cm-calibration" input.ras >>output.pdf
> $ foomatic-rip -p foo -o cm-calibration
> 
> Joe Simon

I have looked into foomatic-rip and it seems that the "cm-calibration"
option only works when using foomatic-rip in direc/spooler-less mode. To
make it also working in CUPS mode you will probably also have to check
it in the first loop in the process_cmdline_options() function.

In imagetoraster you are not only renamimg the option and the variable
but also dropping "else cm_off = 0;" With this probably you need to
preset the variable to zero at declaration ("int cm_calibrate = 0;").

Rest seems to be OK.

Please check these points, as I only reviewed your commit but did not
actually test it.

It would be also nice if you add to all filters with the
"cm-calibration" option a line which generates debug log output telling
whether "cm-calibration" was set or not, like

fprintf(stderr, "DEBUG: Color Management: %s\n", cm_calibrate ?
"Calibration mode/deactivated" : "Standard mode/activated");

   Till