From: David Vrabel <david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
To: Daniel Kiper
<daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org
Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
jeremy-TSDbQ3PG+2Y@public.gmane.org,
matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
jbeulich-IBi9RG/b67k@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
eshelton-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org
Subject: Re: [Xen-devel] [PATCH v5 3/7] xen: Define EFI related stuff
Date: Mon, 16 Jun 2014 11:54:04 +0100 [thread overview]
Message-ID: <539ECCCC.4030601@citrix.com> (raw)
In-Reply-To: <1402678823-24589-4-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On 13/06/14 18:00, Daniel Kiper wrote:
> Define constants and structures which are needed to properly
> execute EFI related hypercall in Xen dom0.
>
> This patch is based on Jan Beulich and Tang Liang work.
>
> v5 - suggestions/fixes:
This version information should be after a '---' marker.
> + struct {
> + GUEST_HANDLE(void) name; /* UCS-2/UTF-16 string */
> + xen_ulong_t size;
> + GUEST_HANDLE(void) data;
> + struct xenpf_efi_guid {
> + uint32_t data1;
> + uint16_t data2;
> + uint16_t data3;
> + uint8_t data4[8];
> + } vendor_guid;
Indentation looks all messed up here and in many other places.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<x86@kernel.org>, <xen-devel@lists.xenproject.org>
Cc: <mjg59@srcf.ucam.org>, <jeremy@goop.org>,
<matt.fleming@intel.com>, <ian.campbell@citrix.com>,
<andrew.cooper3@citrix.com>, <stefano.stabellini@eu.citrix.com>,
<mingo@redhat.com>, <david.vrabel@citrix.com>,
<jbeulich@suse.com>, <hpa@zytor.com>,
<boris.ostrovsky@oracle.com>, <tglx@linutronix.de>,
<eshelton@pobox.com>
Subject: Re: [Xen-devel] [PATCH v5 3/7] xen: Define EFI related stuff
Date: Mon, 16 Jun 2014 11:54:04 +0100 [thread overview]
Message-ID: <539ECCCC.4030601@citrix.com> (raw)
In-Reply-To: <1402678823-24589-4-git-send-email-daniel.kiper@oracle.com>
On 13/06/14 18:00, Daniel Kiper wrote:
> Define constants and structures which are needed to properly
> execute EFI related hypercall in Xen dom0.
>
> This patch is based on Jan Beulich and Tang Liang work.
>
> v5 - suggestions/fixes:
This version information should be after a '---' marker.
> + struct {
> + GUEST_HANDLE(void) name; /* UCS-2/UTF-16 string */
> + xen_ulong_t size;
> + GUEST_HANDLE(void) data;
> + struct xenpf_efi_guid {
> + uint32_t data1;
> + uint16_t data2;
> + uint16_t data3;
> + uint8_t data4[8];
> + } vendor_guid;
Indentation looks all messed up here and in many other places.
David
next prev parent reply other threads:[~2014-06-16 10:54 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 17:00 [PATCH v5 0/7] xen: Add EFI support Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*() Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
[not found] ` <1402678823-24589-2-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-16 1:19 ` Matthew Garrett
2014-06-16 1:19 ` Matthew Garrett
2014-06-16 1:19 ` Matthew Garrett
2014-06-18 12:17 ` Matt Fleming
2014-06-18 12:17 ` Matt Fleming
2014-06-18 12:31 ` David Vrabel
[not found] ` <20140618121709.GF24049-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-06-18 12:31 ` David Vrabel
2014-06-18 12:31 ` David Vrabel
2014-06-18 13:59 ` Mark Salter
2014-06-18 13:59 ` Mark Salter
2014-06-18 12:59 ` Daniel Kiper
2014-06-18 12:59 ` Daniel Kiper
2014-06-18 14:56 ` Matt Fleming
[not found] ` <20140618125957.GA28489-fJNZiO034lp9pOct4yEdx/3oZC3j2Omk@public.gmane.org>
2014-06-18 14:56 ` Matt Fleming
2014-06-18 14:56 ` Matt Fleming
2014-06-18 13:59 ` Mark Salter
2014-06-13 17:00 ` [PATCH v5 2/7] efi: Introduce EFI_NO_DIRECT flag Daniel Kiper
2014-06-16 10:52 ` David Vrabel
[not found] ` <1402678823-24589-3-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-16 10:52 ` [Xen-devel] " David Vrabel
2014-06-16 10:52 ` David Vrabel
2014-06-18 13:52 ` Matt Fleming
2014-06-18 13:52 ` Matt Fleming
2014-06-18 13:58 ` Jan Beulich
2014-06-18 16:48 ` Daniel Kiper
[not found] ` <20140618135229.GH24049-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-06-18 13:58 ` Jan Beulich
2014-06-18 13:58 ` Jan Beulich
2014-06-18 14:30 ` Stefano Stabellini
[not found] ` <53A1B726020000780001B6CF-tRfBTM6QL9aeHWOVceGJHFaTQe2KTcn/@public.gmane.org>
2014-06-18 14:30 ` Stefano Stabellini
2014-06-18 14:30 ` Stefano Stabellini
2014-06-18 15:08 ` Daniel Kiper
[not found] ` <alpine.DEB.2.02.1406181523340.13771-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2014-06-18 15:08 ` Daniel Kiper
2014-06-18 15:08 ` Daniel Kiper
2014-06-18 15:12 ` Matt Fleming
2014-06-18 15:12 ` Matt Fleming
2014-06-18 15:12 ` Matt Fleming
2014-06-18 16:48 ` Daniel Kiper
2014-06-18 16:48 ` Daniel Kiper
2014-06-19 14:41 ` Matt Fleming
[not found] ` <20140618164835.GD28489-fJNZiO034lp9pOct4yEdx/3oZC3j2Omk@public.gmane.org>
2014-06-19 14:41 ` Matt Fleming
2014-06-19 14:41 ` Matt Fleming
[not found] ` <20140619144112.GT24049-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-06-20 14:36 ` Daniel Kiper
2014-06-20 14:36 ` Daniel Kiper
2014-06-20 14:36 ` Daniel Kiper
2014-06-18 13:52 ` Matt Fleming
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 3/7] xen: Define EFI related stuff Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
[not found] ` <1402678823-24589-4-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-16 10:54 ` David Vrabel [this message]
2014-06-16 10:54 ` [Xen-devel] " David Vrabel
2014-06-16 10:54 ` David Vrabel
2014-06-13 17:00 ` [PATCH v5 4/7] xen: Put EFI machinery in place Daniel Kiper
2014-06-16 11:55 ` Stefano Stabellini
2014-06-16 11:55 ` Stefano Stabellini
2014-06-16 18:45 ` Daniel Kiper
[not found] ` <alpine.DEB.2.02.1406161245490.13771-7Z66fg9igcxYtxbxJUhB2Dgeux46jI+i@public.gmane.org>
2014-06-16 18:45 ` Daniel Kiper
2014-06-16 18:45 ` Daniel Kiper
2014-06-16 11:55 ` Stefano Stabellini
[not found] ` <1402678823-24589-5-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-16 12:00 ` David Vrabel
2014-06-16 12:00 ` David Vrabel
2014-06-16 19:06 ` Daniel Kiper
[not found] ` <539EDC5D.4010207-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-06-16 19:06 ` Daniel Kiper
2014-06-16 19:06 ` Daniel Kiper
2014-06-16 12:00 ` David Vrabel
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 5/7] arch/x86: Replace plain strings with constants Daniel Kiper
2014-06-18 13:56 ` Matt Fleming
[not found] ` <1402678823-24589-6-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-18 13:56 ` Matt Fleming
2014-06-18 13:56 ` Matt Fleming
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 6/7] arch/x86: Remove redundant set_bit() call Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-18 13:56 ` Matt Fleming
[not found] ` <1402678823-24589-7-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-18 13:56 ` Matt Fleming
2014-06-18 13:56 ` Matt Fleming
2014-06-18 14:01 ` Konrad Rzeszutek Wilk
[not found] ` <20140618135637.GJ24049-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-06-18 14:01 ` Konrad Rzeszutek Wilk
2014-06-18 14:01 ` Konrad Rzeszutek Wilk
2014-06-18 14:09 ` Matt Fleming
[not found] ` <20140618140101.GC4651-0iZWjJA6G8GSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2014-06-18 14:09 ` Matt Fleming
2014-06-18 14:09 ` Matt Fleming
2014-06-13 17:00 ` [PATCH v5 7/7] arch/x86: Comment out efi_set_rtc_mmss() Daniel Kiper
[not found] ` <1402678823-24589-1-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-16 11:43 ` Stefano Stabellini
2014-06-16 11:43 ` Stefano Stabellini
2014-06-16 11:54 ` Juergen Gross
2014-06-16 11:54 ` [Xen-devel] " Juergen Gross
2014-06-16 18:59 ` H. Peter Anvin
[not found] ` <539EDAE9.7000605-IBi9RG/b67k@public.gmane.org>
2014-06-16 18:59 ` [Xen-devel] " H. Peter Anvin
2014-06-16 18:59 ` H. Peter Anvin
2014-06-16 11:43 ` Stefano Stabellini
[not found] ` <1402678823-24589-8-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-18 14:08 ` Matt Fleming
2014-06-18 14:08 ` Matt Fleming
2014-06-18 14:08 ` Matt Fleming
2014-06-18 14:15 ` [PATCH v5 0/7] xen: Add EFI support Matt Fleming
2014-06-18 14:15 ` Matt Fleming
[not found] ` <20140618141541.GM24049-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-06-18 14:31 ` Konrad Rzeszutek Wilk
2014-06-18 14:31 ` Konrad Rzeszutek Wilk
[not found] ` <20140618143143.GB8545-0iZWjJA6G8GSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2014-06-18 14:48 ` Matt Fleming
2014-06-18 14:48 ` Matt Fleming
2014-06-18 14:48 ` Matt Fleming
2014-06-18 14:31 ` Konrad Rzeszutek Wilk
2014-06-18 14:15 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539ECCCC.4030601@citrix.com \
--to=david.vrabel-sxgqhf6nn4dqt0dzr+alfa@public.gmane.org \
--cc=andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=eshelton-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=jbeulich-IBi9RG/b67k@public.gmane.org \
--cc=jeremy-TSDbQ3PG+2Y@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.