From: Andrew Cooper <andrew.cooper3@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
ian.campbell@citrix.com
Subject: Re: [PATCH v2 1/4] xentrace: Use PERROR from xc_private. instead of our own.
Date: Mon, 16 Jun 2014 12:49:25 +0100 [thread overview]
Message-ID: <539ED9C5.3010306@citrix.com> (raw)
In-Reply-To: <539ED852.7060603@eu.citrix.com>
On 16/06/14 12:43, George Dunlap wrote:
> On 06/13/2014 09:41 PM, Konrad Rzeszutek Wilk wrote:
>> However, the xc_private PERROR uses 'xch' while we call said
>> structure 'xc_handle' - so this patch also changes the variable
>> to xch.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> I wasn't sure whether "xc_private.h" was intended to be included by
> tools outside the libxc directory, but it seems to be included by
> xenpaging and a couple of random things inside tools/misc; so:
>
> Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>
I disagree - xc_private.h is private to libxc and should not be used
outside of tools/libxc/*
There are some naughty examples which should be fixed.
If there are bits in xc_private.h which are needed by outside programs,
then they should move to xen{ctrl,guest}.h as appropriate.
~Andrew
next prev parent reply other threads:[~2014-06-16 11:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 20:41 [PATCH v2] Support CPU-list parsing in xentrace Konrad Rzeszutek Wilk
2014-06-13 20:41 ` [PATCH v2 1/4] xentrace: Use PERROR from xc_private. instead of our own Konrad Rzeszutek Wilk
2014-06-16 11:43 ` George Dunlap
2014-06-16 11:46 ` Ian Campbell
2014-06-16 11:49 ` Andrew Cooper [this message]
2014-06-16 13:43 ` Konrad Rzeszutek Wilk
2014-06-13 20:41 ` [PATCH v2 2/4] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t Konrad Rzeszutek Wilk
2014-06-16 13:30 ` George Dunlap
2014-06-16 13:43 ` Konrad Rzeszutek Wilk
2014-06-13 20:41 ` [PATCH v2 3/4] libxc/tbuf: Use the xc_hypercall_bounce_[pre|post] instead of memcpy Konrad Rzeszutek Wilk
2014-06-18 13:55 ` Ian Campbell
2014-06-18 13:59 ` Konrad Rzeszutek Wilk
2014-06-13 20:41 ` [PATCH v2 4/4] xentrace: Implement cpu mask range parsing of human values (-c) Konrad Rzeszutek Wilk
2014-06-16 14:36 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539ED9C5.3010306@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.