From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: rcar-gen2: correct return value of shmobile_smp_apmu_suspend_init
Date: Mon, 16 Jun 2014 12:13:38 +0000 [thread overview]
Message-ID: <539EDF72.7080305@cogentembedded.com> (raw)
In-Reply-To: <1402918044-29961-1-git-send-email-horms+renesas@verge.net.au>
Hello.
On 06/16/2014 03:27 PM, Simon Horman wrote:
> The dummy shmobile_smp_apmu_suspend_init() function provided when
> CPU_IDLE is not set should not return a value as per the signature
> of the function.
> This problem appears to have been introduced by
> 867ba81f728f1daa ("ARM: shmobile: APMU: Add Core-Standby-state for Suspend
> to RAM").
> Cc: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]
> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> index 8f0cd57..46766fc 100644
> --- a/arch/arm/mach-shmobile/include/mach/common.h
> +++ b/arch/arm/mach-shmobile/include/mach/common.h
> @@ -38,7 +38,7 @@ int shmobile_suspend_init(void);
> void shmobile_smp_apmu_suspend_init(void);
> #else
> static inline int shmobile_suspend_init(void) { return 0; }
> -static inline void shmobile_smp_apmu_suspend_init(void) { return 0; }
> +static inline void shmobile_smp_apmu_suspend_init(void) { return; }
I wonder why you kept *return* at all?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: rcar-gen2: correct return value of shmobile_smp_apmu_suspend_init
Date: Mon, 16 Jun 2014 16:13:38 +0400 [thread overview]
Message-ID: <539EDF72.7080305@cogentembedded.com> (raw)
In-Reply-To: <1402918044-29961-1-git-send-email-horms+renesas@verge.net.au>
Hello.
On 06/16/2014 03:27 PM, Simon Horman wrote:
> The dummy shmobile_smp_apmu_suspend_init() function provided when
> CPU_IDLE is not set should not return a value as per the signature
> of the function.
> This problem appears to have been introduced by
> 867ba81f728f1daa ("ARM: shmobile: APMU: Add Core-Standby-state for Suspend
> to RAM").
> Cc: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]
> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> index 8f0cd57..46766fc 100644
> --- a/arch/arm/mach-shmobile/include/mach/common.h
> +++ b/arch/arm/mach-shmobile/include/mach/common.h
> @@ -38,7 +38,7 @@ int shmobile_suspend_init(void);
> void shmobile_smp_apmu_suspend_init(void);
> #else
> static inline int shmobile_suspend_init(void) { return 0; }
> -static inline void shmobile_smp_apmu_suspend_init(void) { return 0; }
> +static inline void shmobile_smp_apmu_suspend_init(void) { return; }
I wonder why you kept *return* at all?
WBR, Sergei
next prev parent reply other threads:[~2014-06-16 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 11:27 [PATCH] ARM: shmobile: rcar-gen2: correct return value of shmobile_smp_apmu_suspend_init Simon Horman
2014-06-16 11:27 ` Simon Horman
2014-06-16 12:13 ` Sergei Shtylyov [this message]
2014-06-16 12:13 ` Sergei Shtylyov
2014-06-16 12:25 ` Simon Horman
2014-06-16 12:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539EDF72.7080305@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.