From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nick Krause <xerofoify@gmail.com>, David Miller <davem@davemloft.net>
Cc: andriy.shevchenko@linux.intel.com, dvhart@linux.intel.com,
jeffrey.t.kirsher@intel.com, ast@plumgrid.com,
dborkman@redhat.com, bhutchings@solarflare.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()
Date: Mon, 16 Jun 2014 17:32:25 +0400 [thread overview]
Message-ID: <539EF1E9.8070607@cogentembedded.com> (raw)
In-Reply-To: <CAPDOMVgV8V8fPpZupwQaDERiK-0OMLt66LULR6Biw1=8LJhOKw@mail.gmail.com>
Hello.
On 06/16/2014 12:27 AM, Nick Krause wrote:
> From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001
> From: Nick <xerofoify@gmail.com>
> Date: Sun, 15 Jun 2014 16:16:14 -0400
> Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers()
> Here is the fixed patch changed return type of function to int in
> order to use return -ENOMEM as with the function above it , seems to
> fit , otherwise returns 0.
> Report if it breaks anything related to this driver.
> Signed-off-by: Nick <xerofoify@gmail.com>
You should specify your full name in the "Signed-off:" line.
WBR, Sergei
prev parent reply other threads:[~2014-06-16 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 4:05 [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb() Nick
2014-06-15 4:39 ` Nick Krause
2014-06-15 6:53 ` David Miller
2014-06-15 20:27 ` Nick Krause
2014-06-16 2:26 ` David Miller
2014-06-16 3:28 ` Nick Krause
2014-06-16 13:32 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539EF1E9.8070607@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@plumgrid.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dvhart@linux.intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.