Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

["Stefan (metze) Metzmacher" <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Hi Steve,

any comments on this? How can we get this fixed upstream?

Thanks!
metze

Am 10.06.2014 12:03, schrieb Björn Baumbach:
> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
> ("CIFS: Cleanup cifs open codepath")
> changed disposition to FILE_OPEN.
> 
> Signed-off-by: Björn Baumbach <bb-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org>
> Signed-off-by: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> Reviewed-by: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.14+
> Cc: Pavel Shilovsky <piastry-7qunaywFIewox3rIn2DAYQ@public.gmane.org>
> Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
>  fs/cifs/link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index 264ece7..68559fd 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>  	oparms.cifs_sb = cifs_sb;
>  	oparms.desired_access = GENERIC_WRITE;
>  	oparms.create_options = create_options;
> -	oparms.disposition = FILE_OPEN;
> +	oparms.disposition = FILE_CREATE;
>  	oparms.path = path;
>  	oparms.fid = &fid;
>  	oparms.reconnect = false;
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]