* [PATCH] tile: use ARRAY_SIZE
@ 2014-06-16 20:12 Himangi Saraogi
2014-06-16 20:20 ` Chris Metcalf
0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-06-16 20:12 UTC (permalink / raw)
To: Chris Metcalf, linux-kernel; +Cc: julia.lawall
ARRAY_SIZE is more concise to use when the size of an array is divided
by the size of its type or the size of its first element.
The semantic patch that makes this change is as follows:
// <smpl>
@i@
@@
@@
type T;
T[] E;
@@
- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
Not compile tested.
arch/tile/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/tile/kernel/traps.c b/arch/tile/kernel/traps.c
index f3ceb63..86900cc 100644
--- a/arch/tile/kernel/traps.c
+++ b/arch/tile/kernel/traps.c
@@ -277,7 +277,7 @@ void __kprobes do_trap(struct pt_regs *regs, int fault_num,
if (fixup_exception(regs)) /* ILL_TRANS or UNALIGN_DATA */
return;
if (fault_num >= 0 &&
- fault_num < sizeof(int_name)/sizeof(int_name[0]) &&
+ fault_num < ARRAY_SIZE(int_name) &&
int_name[fault_num] != NULL)
name = int_name[fault_num];
else
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tile: use ARRAY_SIZE
2014-06-16 20:12 [PATCH] tile: use ARRAY_SIZE Himangi Saraogi
@ 2014-06-16 20:20 ` Chris Metcalf
0 siblings, 0 replies; 2+ messages in thread
From: Chris Metcalf @ 2014-06-16 20:20 UTC (permalink / raw)
To: Himangi Saraogi, linux-kernel; +Cc: julia.lawall
On 6/16/2014 4:12 PM, Himangi Saraogi wrote:
> ARRAY_SIZE is more concise to use when the size of an array is divided
> by the size of its type or the size of its first element.
>
> The semantic patch that makes this change is as follows:
>
> // <smpl>
> @i@
> @@
>
> @@
> type T;
> T[] E;
> @@
>
> - (sizeof(E)/sizeof(T))
> + ARRAY_SIZE(E)
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> Not compile tested.
> arch/tile/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, taken into the tile tree.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 20:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 20:12 [PATCH] tile: use ARRAY_SIZE Himangi Saraogi
2014-06-16 20:20 ` Chris Metcalf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.