* [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
@ 2014-06-17 10:23 chenweilong
2014-08-05 18:18 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: chenweilong @ 2014-06-17 10:23 UTC (permalink / raw)
To: gregkh, David Miller; +Cc: netdev, stable, Li Zefan
Hi Greg,
Please queue this for 3.4 stable kernel.
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either. So I had to write this one.
====================
From: Gao feng <gaofeng@cn.fujitsu.com>
commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.
The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
CC: Sabrina Dubroca <sd@queasysnail.net>
CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
Reported-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <chenweilong@huawei.com>
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
net/ipv6/addrconf.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
continue;
- if (sp_ifa->rt)
- continue;
+ if (sp_ifa->rt) {
+ /* This dst has been added to garbage list when
+ * lo device down, release this obsolete dst and
+ * reallocate a new router for ifa.
+ */
+ if (sp_ifa->rt->dst.obsolete > 0) {
+ dst_release(sp_ifa->rt);
+ sp_ifa->rt = NULL;
+ } else {
+ continue;
+ }
+ }
sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
-- 1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
2014-06-17 10:23 [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up chenweilong
@ 2014-08-05 18:18 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-08-05 18:18 UTC (permalink / raw)
To: chenweilong; +Cc: David Miller, netdev, stable, Li Zefan
On Tue, Jun 17, 2014 at 06:23:59PM +0800, chenweilong wrote:
> Hi Greg,
>
> Please queue this for 3.4 stable kernel.
>
> It fix the bug 67951 on bugzilla
> https://bugzilla.kernel.org/show_bug.cgi?id=67951
>
> The patch can't be applied directly, as it' used the function introduced
> by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
> either. So I had to write this one.
Now applied, can you also provide a version for 3.10-stable as I think
it is needd there also, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
@ 2014-06-19 0:50 chenweilong
2014-07-25 4:08 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: chenweilong @ 2014-06-19 0:50 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi David,
Please queue this for 3.4 stable kernel.
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either. So I had to write this one.
====================
From: Gao feng <gaofeng@cn.fujitsu.com>
commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.
The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
CC: Sabrina Dubroca <sd@queasysnail.net>
CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
Reported-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <chenweilong@huawei.com>
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
net/ipv6/addrconf.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
continue;
- if (sp_ifa->rt)
- continue;
+ if (sp_ifa->rt) {
+ /* This dst has been added to garbage list when
+ * lo device down, release this obsolete dst and
+ * reallocate a new router for ifa.
+ */
+ if (sp_ifa->rt->dst.obsolete > 0) {
+ dst_release(sp_ifa->rt);
+ sp_ifa->rt = NULL;
+ } else {
+ continue;
+ }
+ }
sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
-- 1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
2014-06-19 0:50 chenweilong
@ 2014-07-25 4:08 ` David Miller
2014-08-06 8:01 ` chenweilong
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2014-07-25 4:08 UTC (permalink / raw)
To: chenweilong; +Cc: netdev
From: chenweilong <chenweilong@huawei.com>
Date: Thu, 19 Jun 2014 08:50:33 +0800
> Please queue this for 3.4 stable kernel.
...
> + dst_release(sp_ifa->rt);
dst_release() does not take a "struct rt6_info *", and therefore
the compile warns when you try to compile this.
For something like -stable, we should be as conservative as possible,
I expect at a minimum that you look at the build for warnings added by
your change.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
2014-07-25 4:08 ` David Miller
@ 2014-08-06 8:01 ` chenweilong
0 siblings, 0 replies; 6+ messages in thread
From: chenweilong @ 2014-08-06 8:01 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Sorry.
I'll change it.
On 2014/7/25 12:08, David Miller wrote:
> From: chenweilong <chenweilong@huawei.com>
> Date: Thu, 19 Jun 2014 08:50:33 +0800
>
>> Please queue this for 3.4 stable kernel.
> ...
>> + dst_release(sp_ifa->rt);
>
> dst_release() does not take a "struct rt6_info *", and therefore
> the compile warns when you try to compile this.
>
> For something like -stable, we should be as conservative as possible,
> I expect at a minimum that you look at the build for warnings added by
> your change.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
@ 2014-07-09 1:35 chenweilong
0 siblings, 0 replies; 6+ messages in thread
From: chenweilong @ 2014-07-09 1:35 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi David,
Please queue this for 3.4 stable kernel.
It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either.
====================
From: Gao feng <gaofeng@cn.fujitsu.com>
commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.
The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
CC: Sabrina Dubroca <sd@queasysnail.net>
CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
Reported-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <chenweilong@huawei.com>
---
net/ipv6/addrconf.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
continue;
- if (sp_ifa->rt)
- continue;
+ if (sp_ifa->rt) {
+ /* This dst has been added to garbage list when
+ * lo device down, release this obsolete dst and
+ * reallocate a new router for ifa.
+ */
+ if (sp_ifa->rt->dst.obsolete > 0) {
+ dst_release(sp_ifa->rt);
+ sp_ifa->rt = NULL;
+ } else {
+ continue;
+ }
+ }
sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
-- 1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-06 8:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 10:23 [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up chenweilong
2014-08-05 18:18 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-06-19 0:50 chenweilong
2014-07-25 4:08 ` David Miller
2014-08-06 8:01 ` chenweilong
2014-07-09 1:35 chenweilong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.