From: Alexander Graf <agraf@suse.de>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] target-ppc: Fix compiler warning
Date: Tue, 17 Jun 2014 21:40:07 +0200 [thread overview]
Message-ID: <53A09997.4030705@suse.de> (raw)
In-Reply-To: <1403025508-19171-1-git-send-email-sw@weilnetz.de>
On 17.06.14 19:18, Stefan Weil wrote:
> gcc reports a warning which is usually wrong:
>
> target-ppc/dfp_helper.c: In function ‘dfp_get_digit’:
> target-ppc/dfp_helper.c:417:1: warning:
> control reaches end of non-void function [-Wreturn-type]
>
> The compiler shows the warning if assert is not marked with the noreturn
> attribute or if the code is compiled with -DNDEBUG.
>
> Using g_assert_not_reached better documents the intention and does not
> have these problems.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Alexander Graf <agraf@suse.de>
Please take it via -trivial.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Fix compiler warning
Date: Tue, 17 Jun 2014 21:40:07 +0200 [thread overview]
Message-ID: <53A09997.4030705@suse.de> (raw)
In-Reply-To: <1403025508-19171-1-git-send-email-sw@weilnetz.de>
On 17.06.14 19:18, Stefan Weil wrote:
> gcc reports a warning which is usually wrong:
>
> target-ppc/dfp_helper.c: In function ‘dfp_get_digit’:
> target-ppc/dfp_helper.c:417:1: warning:
> control reaches end of non-void function [-Wreturn-type]
>
> The compiler shows the warning if assert is not marked with the noreturn
> attribute or if the code is compiled with -DNDEBUG.
>
> Using g_assert_not_reached better documents the intention and does not
> have these problems.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Alexander Graf <agraf@suse.de>
Please take it via -trivial.
Alex
next prev parent reply other threads:[~2014-06-17 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 17:18 [Qemu-trivial] [PATCH] target-ppc: Fix compiler warning Stefan Weil
2014-06-17 17:18 ` [Qemu-devel] " Stefan Weil
2014-06-17 19:40 ` Alexander Graf [this message]
2014-06-17 19:40 ` Alexander Graf
2014-06-21 12:39 ` [Qemu-trivial] " Michael Tokarev
2014-06-21 12:39 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A09997.4030705@suse.de \
--to=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.