All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 12/24] drivers/parisc: return actual error on pdc_stable_init
@ 2014-06-17 14:30 Jeff Liu
  2014-06-18  1:46 ` Jeff Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Liu @ 2014-06-17 14:30 UTC (permalink / raw)
  To: JBottomley, deller; +Cc: linux-parisc

From: Jie Liu <jeff.liu@oracle.com>

Return the actual error code than ENOMEM if call kset_create_and_add()
failed at pdc_stable_init().

Cc: James E.J. Bottomley <jejb@parisc-linux.org>
Cc: Helge Deller <deller@gmx.de>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 drivers/parisc/pdc_stable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
index 0f54ab6..3daca50 100644
--- a/drivers/parisc/pdc_stable.c
+++ b/drivers/parisc/pdc_stable.c
@@ -1065,8 +1065,8 @@ pdc_stable_init(void)
 
 	/* register the paths kset as a child of the stable kset */
 	paths_kset = kset_create_and_add("paths", NULL, stable_kobj);
-	if (!paths_kset) {
-		rc = -ENOMEM;
+	if (IS_ERR(paths_kset)) {
+		rc = PTR_ERR(paths_kset);
 		goto fail_ksetreg;
 	}
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 12/24] drivers/parisc: return actual error on pdc_stable_init
  2014-06-17 14:30 [PATCH 12/24] drivers/parisc: return actual error on pdc_stable_init Jeff Liu
@ 2014-06-18  1:46 ` Jeff Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Liu @ 2014-06-18  1:46 UTC (permalink / raw)
  To: JBottomley, deller; +Cc: linux-parisc, Greg KH

Hi,

On 06/17/2014 22:30 PM, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> Return the actual error code than ENOMEM if call kset_create_and_add()
> failed at pdc_stable_init().
> 
> Cc: James E.J. Bottomley <jejb@parisc-linux.org>
> Cc: Helge Deller <deller@gmx.de>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>

Please ignore this patch because Greg think that is incorrect.

Cheers,
-Jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-18  1:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 14:30 [PATCH 12/24] drivers/parisc: return actual error on pdc_stable_init Jeff Liu
2014-06-18  1:46 ` Jeff Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.