All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
	stefano.stabellini@citrix.com
Subject: Re: [PATCH] xen/arm: Panic when we receive an unexpected trap
Date: Wed, 18 Jun 2014 17:08:19 +0100	[thread overview]
Message-ID: <53A1B973.20805@linaro.org> (raw)
In-Reply-To: <1403107337.6568.110.camel@kazak.uk.xensource.com>

On 06/18/2014 05:02 PM, Ian Campbell wrote:
> On Tue, 2014-06-17 at 21:44 +0100, Julien Grall wrote:
>> The current implementation of do_unexpected_trap make Xen spin forever
>> on the current physical CPU. This may lead to stall guests VCPU and print
>> unhelpful message (RCU stall...).
>>
>> Usually when Xen receives an unexpected trap, it means that something goes
>> wrong either in the hypervisor or in the CPU. In this case we should
>> directly panic to also stop the other CPUs.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Ack + applied.

Thanks, I think this patch is a good candidate for backporting on Xen 4.4

It will avoid Xen to try to continue running when an unexpected trap occurs.

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-06-18 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 20:44 [PATCH] xen/arm: Panic when we receive an unexpected trap Julien Grall
2014-06-18 16:02 ` Ian Campbell
2014-06-18 16:08   ` Julien Grall [this message]
2014-06-18 16:41     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A1B973.20805@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.