From: Eric Blake <eblake@redhat.com>
To: "Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [qom-cpu PATCH 2/3] target-i386: Remove unsupported bits from all CPU models
Date: Wed, 18 Jun 2014 14:52:38 -0600 [thread overview]
Message-ID: <53A1FC16.9090105@redhat.com> (raw)
In-Reply-To: <1403121359-4275-3-git-send-email-ehabkost@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On 06/18/2014 01:55 PM, Eduardo Habkost wrote:
> The following CPU features were never supported by neither TCG or KVM,
> so they are useless on the CPU model definitions, today:
>
The overall idea of this series makes sense to me (yes, I'd love to get
libvirt to the point that we can use enforce mode), but I decline to
review the actual contents (it's a bit over my head how all the models
work) and leave it to the experts. But here's a trivial finding:
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 8de1566..2f32d29 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -680,10 +680,11 @@ static X86CPUDefinition builtin_x86_defs[] = {
> .family = 16,
> .model = 2,
> .stepping = 3,
> + /* MIssing: CPUID_HT */
s/MIssing/Missing/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: "Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>,
kvm@vger.kernel.org, Aurelien Jarno <aurelien@aurel32.net>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [qom-cpu PATCH 2/3] target-i386: Remove unsupported bits from all CPU models
Date: Wed, 18 Jun 2014 14:52:38 -0600 [thread overview]
Message-ID: <53A1FC16.9090105@redhat.com> (raw)
In-Reply-To: <1403121359-4275-3-git-send-email-ehabkost@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On 06/18/2014 01:55 PM, Eduardo Habkost wrote:
> The following CPU features were never supported by neither TCG or KVM,
> so they are useless on the CPU model definitions, today:
>
The overall idea of this series makes sense to me (yes, I'd love to get
libvirt to the point that we can use enforce mode), but I decline to
review the actual contents (it's a bit over my head how all the models
work) and leave it to the experts. But here's a trivial finding:
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 8de1566..2f32d29 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -680,10 +680,11 @@ static X86CPUDefinition builtin_x86_defs[] = {
> .family = 16,
> .model = 2,
> .stepping = 3,
> + /* MIssing: CPUID_HT */
s/MIssing/Missing/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-18 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 19:55 [qom-cpu PATCH 0/3] target-i386: Make most CPU models work with "enforce" out of the box Eduardo Habkost
2014-06-18 19:55 ` [Qemu-devel] " Eduardo Habkost
2014-06-18 19:55 ` [qom-cpu PATCH 1/3] target-i386: Disable CPUID_ACPI by default on KVM mode Eduardo Habkost
2014-06-18 19:55 ` [Qemu-devel] " Eduardo Habkost
2014-06-18 19:55 ` [qom-cpu PATCH 2/3] target-i386: Remove unsupported bits from all CPU models Eduardo Habkost
2014-06-18 19:55 ` [Qemu-devel] " Eduardo Habkost
2014-06-18 20:52 ` Eric Blake [this message]
2014-06-18 20:52 ` Eric Blake
2014-06-18 19:55 ` [qom-cpu PATCH 3/3] target-i386: Don't enable nested VMX by default Eduardo Habkost
2014-06-18 19:55 ` [Qemu-devel] " Eduardo Habkost
2014-06-19 9:23 ` Paolo Bonzini
2014-06-19 9:23 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1FC16.9090105@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.