From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@parallels.com>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: slab.h: wrap the whole file with guarding macro
Date: Thu, 19 Jun 2014 11:29:28 +0400 [thread overview]
Message-ID: <53A29158.2050809@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406181321010.10339@chino.kir.corp.google.com>
On 06/19/14 00:22, David Rientjes wrote:
> On Wed, 18 Jun 2014, Andrey Ryabinin wrote:
>
>> Guarding section:
>> #ifndef MM_SLAB_H
>> #define MM_SLAB_H
>> ...
>> #endif
>> currently doesn't cover the whole mm/slab.h. It seems like it was
>> done unintentionally.
>>
>> Wrap the whole file by moving closing #endif to the end of it.
>>
>> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> Looks like
>
> ca34956b804b ("slab: Common definition for kmem_cache_node")
> e25839f67948 ("mm/slab: Sharing s_next and s_stop between slab and slub
> 276a2439ce79 ("mm/slab: Give s_next and s_stop slab-specific names")
>
> added onto the header without the guard and it has been this way since
> Jan 10 2013. Andrey, how did you notice that this was an issue? Simply
> by visual inspection?
>
I had to do some modifications in this file for some reasons, and for me it was hard to not
notice lack of endif in the end.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@parallels.com>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: slab.h: wrap the whole file with guarding macro
Date: Thu, 19 Jun 2014 11:29:28 +0400 [thread overview]
Message-ID: <53A29158.2050809@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406181321010.10339@chino.kir.corp.google.com>
On 06/19/14 00:22, David Rientjes wrote:
> On Wed, 18 Jun 2014, Andrey Ryabinin wrote:
>
>> Guarding section:
>> #ifndef MM_SLAB_H
>> #define MM_SLAB_H
>> ...
>> #endif
>> currently doesn't cover the whole mm/slab.h. It seems like it was
>> done unintentionally.
>>
>> Wrap the whole file by moving closing #endif to the end of it.
>>
>> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> Looks like
>
> ca34956b804b ("slab: Common definition for kmem_cache_node")
> e25839f67948 ("mm/slab: Sharing s_next and s_stop between slab and slub
> 276a2439ce79 ("mm/slab: Give s_next and s_stop slab-specific names")
>
> added onto the header without the guard and it has been this way since
> Jan 10 2013. Andrey, how did you notice that this was an issue? Simply
> by visual inspection?
>
I had to do some modifications in this file for some reasons, and for me it was hard to not
notice lack of endif in the end.
next prev parent reply other threads:[~2014-06-19 7:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:11 [PATCH] mm: slab.h: wrap the whole file with guarding macro Andrey Ryabinin
2014-06-18 14:11 ` Andrey Ryabinin
2014-06-18 14:26 ` Christoph Lameter
2014-06-18 14:26 ` Christoph Lameter
2014-06-18 20:22 ` David Rientjes
2014-06-18 20:22 ` David Rientjes
2014-06-19 7:29 ` Andrey Ryabinin [this message]
2014-06-19 7:29 ` Andrey Ryabinin
2014-06-19 9:13 ` David Rientjes
2014-06-19 9:13 ` David Rientjes
2014-06-19 14:37 ` Christoph Lameter
2014-06-19 14:37 ` Christoph Lameter
2014-06-19 7:17 ` Vladimir Davydov
2014-06-19 7:17 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A29158.2050809@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.