* [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
@ 2014-06-04 1:37 ` Sam Bobroff
0 siblings, 0 replies; 8+ messages in thread
From: Sam Bobroff @ 2014-06-04 1:37 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Allow "make install" to handle tool binaries that reside in
sub-directories.
Without this patch "make install" will fail if it needs to strip
a tool binary (e.g. debugging is not enabled) that is installed
from a subdirectory. An example is fsdev/virtfs-proxy-helper.
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d830483..9c23265 100644
--- a/Makefile
+++ b/Makefile
@@ -380,7 +380,7 @@ install-datadir install-localstatedir
ifneq ($(TOOLS),)
$(INSTALL_PROG) $(TOOLS) "$(DESTDIR)$(bindir)"
ifneq ($(STRIP),)
- $(STRIP) $(TOOLS:%="$(DESTDIR)$(bindir)/%")
+ $(STRIP) $(foreach T,$(TOOLS),"$(DESTDIR)$(bindir)/$(notdir $T)")
endif
endif
ifneq ($(CONFIG_MODULES),)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Qemu-devel] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
@ 2014-06-04 1:37 ` Sam Bobroff
0 siblings, 0 replies; 8+ messages in thread
From: Sam Bobroff @ 2014-06-04 1:37 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Allow "make install" to handle tool binaries that reside in
sub-directories.
Without this patch "make install" will fail if it needs to strip
a tool binary (e.g. debugging is not enabled) that is installed
from a subdirectory. An example is fsdev/virtfs-proxy-helper.
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d830483..9c23265 100644
--- a/Makefile
+++ b/Makefile
@@ -380,7 +380,7 @@ install-datadir install-localstatedir
ifneq ($(TOOLS),)
$(INSTALL_PROG) $(TOOLS) "$(DESTDIR)$(bindir)"
ifneq ($(STRIP),)
- $(STRIP) $(TOOLS:%="$(DESTDIR)$(bindir)/%")
+ $(STRIP) $(foreach T,$(TOOLS),"$(DESTDIR)$(bindir)/$(notdir $T)")
endif
endif
ifneq ($(CONFIG_MODULES),)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
2014-06-04 1:37 ` [Qemu-devel] " Sam Bobroff
@ 2014-06-04 8:24 ` Peter Maydell
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2014-06-04 8:24 UTC (permalink / raw)
To: Sam Bobroff; +Cc: QEMU Trivial, QEMU Developers
On 4 June 2014 02:37, Sam Bobroff <sam.bobroff@au1.ibm.com> wrote:
> Allow "make install" to handle tool binaries that reside in
> sub-directories.
>
> Without this patch "make install" will fail if it needs to strip
> a tool binary (e.g. debugging is not enabled) that is installed
> from a subdirectory. An example is fsdev/virtfs-proxy-helper.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d830483..9c23265 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -380,7 +380,7 @@ install-datadir install-localstatedir
> ifneq ($(TOOLS),)
> $(INSTALL_PROG) $(TOOLS) "$(DESTDIR)$(bindir)"
> ifneq ($(STRIP),)
> - $(STRIP) $(TOOLS:%="$(DESTDIR)$(bindir)/%")
> + $(STRIP) $(foreach T,$(TOOLS),"$(DESTDIR)$(bindir)/$(notdir $T)")
> endif
> endif
> ifneq ($(CONFIG_MODULES),)
> --
> 1.7.10.4
We should probably also do this on the other invocation of $(STRIP}
for installs into libexecdir.
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
@ 2014-06-04 8:24 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2014-06-04 8:24 UTC (permalink / raw)
To: Sam Bobroff; +Cc: QEMU Trivial, QEMU Developers
On 4 June 2014 02:37, Sam Bobroff <sam.bobroff@au1.ibm.com> wrote:
> Allow "make install" to handle tool binaries that reside in
> sub-directories.
>
> Without this patch "make install" will fail if it needs to strip
> a tool binary (e.g. debugging is not enabled) that is installed
> from a subdirectory. An example is fsdev/virtfs-proxy-helper.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d830483..9c23265 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -380,7 +380,7 @@ install-datadir install-localstatedir
> ifneq ($(TOOLS),)
> $(INSTALL_PROG) $(TOOLS) "$(DESTDIR)$(bindir)"
> ifneq ($(STRIP),)
> - $(STRIP) $(TOOLS:%="$(DESTDIR)$(bindir)/%")
> + $(STRIP) $(foreach T,$(TOOLS),"$(DESTDIR)$(bindir)/$(notdir $T)")
> endif
> endif
> ifneq ($(CONFIG_MODULES),)
> --
> 1.7.10.4
We should probably also do this on the other invocation of $(STRIP}
for installs into libexecdir.
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
2014-06-04 1:37 ` [Qemu-devel] " Sam Bobroff
@ 2014-06-22 6:30 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2014-06-22 6:30 UTC (permalink / raw)
To: Sam Bobroff, qemu-devel; +Cc: qemu-trivial
04.06.2014 05:37, Sam Bobroff пишет:
> Allow "make install" to handle tool binaries that reside in
> sub-directories.
>
> Without this patch "make install" will fail if it needs to strip
> a tool binary (e.g. debugging is not enabled) that is installed
> from a subdirectory. An example is fsdev/virtfs-proxy-helper.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
@ 2014-06-22 6:30 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2014-06-22 6:30 UTC (permalink / raw)
To: Sam Bobroff, qemu-devel; +Cc: qemu-trivial
04.06.2014 05:37, Sam Bobroff пишет:
> Allow "make install" to handle tool binaries that reside in
> sub-directories.
>
> Without this patch "make install" will fail if it needs to strip
> a tool binary (e.g. debugging is not enabled) that is installed
> from a subdirectory. An example is fsdev/virtfs-proxy-helper.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
2014-06-22 6:30 ` [Qemu-devel] " Michael Tokarev
@ 2014-06-22 6:52 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2014-06-22 6:52 UTC (permalink / raw)
To: Sam Bobroff, qemu-devel; +Cc: qemu-trivial
22.06.2014 10:30, Michael Tokarev wrote:
> 04.06.2014 05:37, Sam Bobroff wrote:
>> Allow "make install" to handle tool binaries that reside in
>> sub-directories.
>>
>> Without this patch "make install" will fail if it needs to strip
>> a tool binary (e.g. debugging is not enabled) that is installed
>> from a subdirectory. An example is fsdev/virtfs-proxy-helper.
>
> Applied to -trivial, thank you!
Actually, the more I think about this, the more I dislike it. I'll
introduce a common function to install programs instead.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries
@ 2014-06-22 6:52 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2014-06-22 6:52 UTC (permalink / raw)
To: Sam Bobroff, qemu-devel; +Cc: qemu-trivial
22.06.2014 10:30, Michael Tokarev wrote:
> 04.06.2014 05:37, Sam Bobroff wrote:
>> Allow "make install" to handle tool binaries that reside in
>> sub-directories.
>>
>> Without this patch "make install" will fail if it needs to strip
>> a tool binary (e.g. debugging is not enabled) that is installed
>> from a subdirectory. An example is fsdev/virtfs-proxy-helper.
>
> Applied to -trivial, thank you!
Actually, the more I think about this, the more I dislike it. I'll
introduce a common function to install programs instead.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-22 6:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-04 1:37 [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries Sam Bobroff
2014-06-04 1:37 ` [Qemu-devel] " Sam Bobroff
2014-06-04 8:24 ` [Qemu-trivial] " Peter Maydell
2014-06-04 8:24 ` Peter Maydell
2014-06-22 6:30 ` [Qemu-trivial] " Michael Tokarev
2014-06-22 6:30 ` [Qemu-devel] " Michael Tokarev
2014-06-22 6:52 ` Michael Tokarev
2014-06-22 6:52 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.