Re: [PATCH v3 2/7] ethdev: add autoneg parameter in flow ctrl accessors

[David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

Hello,

On 06/23/2014 05:35 AM, Liu, Jijiang wrote:
> There was an error when we used the following test command to test latest master branch for 10G NIC flow control
> test command:
> ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4-- -i --burst=1 --txpt=32 --txht=8 --txwt=0 --txfreet=0 --rxfreet=64 --mbcache=250 --portmask=f
> testpmd> set flow_ctrl rx off tx off 300 50 10 1 mac_ctrl_frame_fwd on 0
> bad flow contrl parameter, return code = -95
>
> And the reason is that autoneg check failed in ixgbe_flow_ctrl_set() function.
> 	if (fc_conf->autoneg != !hw->fc.disable_fc_autoneg)
> 		return -ENOTSUP;

Ok, indeed, there is a problem with the autoneg field I added.
I will try to send a fix, but I am a bit short on time (and I will be 
offline for a week starting thursday), so if you have a fix before me, 
feel free to send it.


-- 
David Marchand