From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] coroutine-win32.c: Add noinline attribute to work around gcc bug
Date: Mon, 23 Jun 2014 08:55:58 -0700 [thread overview]
Message-ID: <53A84E0E.8070505@twiddle.net> (raw)
In-Reply-To: <53A84184.6090000@redhat.com>
On 06/23/2014 08:02 AM, Paolo Bonzini wrote:
> * I would apply the workaround on all backends, just to be safe. I guess the
> block maintainers can do that.
The other backends don't use TLS, they use pthread_getspecific, which is a
normal function call that gcc will not hoist out of the loop. Therefore the
other backends do not suffer from the same problem.
It's also
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-06-23 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 14:55 [Qemu-devel] [PATCH] coroutine-win32.c: Add noinline attribute to work around gcc bug Peter Maydell
2014-06-23 15:02 ` Paolo Bonzini
2014-06-23 15:55 ` Richard Henderson [this message]
2014-06-26 15:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A84E0E.8070505@twiddle.net \
--to=rth@twiddle.net \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.