Re: UBI: fix rb_tree node comparison in add_map commit buggy?

[Richard Weinberger <richard@nod.at>]

Am 24.06.2014 07:31, schrieb Artem Bityutskiy:
> On Tue, 2014-06-24 at 07:26 +0200, Heiko Schocher wrote:
>> Hello Artem,
>>
>> Am 24.06.2014 06:59, schrieb Artem Bityutskiy:
>>> On Mon, 2014-06-23 at 21:07 +0200, Richard Weinberger wrote:
>>>> I think it would be better to "fix" the whole logic such that low volume ids go into
>>>> the left rb node instead of the right.
>>>> Just to avoid further confusion.
>>>> Artem, do you know why UBI does it the other way around for volume ids?
>>>
>>> I do not remember. Probably no particular reason.
>>>
>>> I'd suggest to do a quick fix first and submit to Linus for 3.16, and
>>> then people can do whatever logic streamlining for 3.17, makes sense?
>>
>> I posted such a patch, but for some reason, I could not find it in
>> http://lists.infradead.org/pipermail/linux-mtd/2014-June/date.html
>>
>> Here an extract from the header I got, as I was on Cc ...
>>
>> From: Heiko Schocher <hs@denx.de>
>> To: linux-mtd@lists.infradead.org
>> Cc: Heiko Schocher <hs@denx.de>,
>> 	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
>> 	Richard Weinberger <richard@nod.at>,
>> 	David Woodhouse <dwmw2@infradead.org>,
>> 	Brian Norris <computersforpeace@gmail.com>,
>> 	Mike Snitzer <snitzer@redhat.com>,
>> 	Wolfgang Denk <wd@denx.de>,
>> 	linux-kernel@vger.kernel.org
>> Subject: [PATCH] ubi: fix correct rb_tree node comparison in add_vol
>> Date: Mon, 23 Jun 2014 15:27:09 +0200
>> Message-Id: <1403530029-12151-1-git-send-email-hs@denx.de>
>> X-Mailer: git-send-email 1.8.3.1
> 
> I do not see it in my @linux.intel.com mailbox either, probably
> something went wrong on your side?

Same here.

Thanks,
//richard