All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: artem.bityutskiy@linux.intel.com
Cc: hs@denx.de, linux-mtd@lists.infradead.org
Subject: Re: UBI: fix rb_tree node comparison in add_map commit buggy?
Date: Tue, 24 Jun 2014 08:53:13 +0200	[thread overview]
Message-ID: <53A92059.5080406@nod.at> (raw)
In-Reply-To: <1403585976.7903.70.camel@sauron.fi.intel.com>

Am 24.06.2014 06:59, schrieb Artem Bityutskiy:
> On Mon, 2014-06-23 at 21:07 +0200, Richard Weinberger wrote:
>> I think it would be better to "fix" the whole logic such that low volume ids go into
>> the left rb node instead of the right.
>> Just to avoid further confusion.
>> Artem, do you know why UBI does it the other way around for volume ids?
> 
> I do not remember. Probably no particular reason.
> 
> I'd suggest to do a quick fix first and submit to Linus for 3.16, and
> then people can do whatever logic streamlining for 3.17, makes sense?

Agreed!

Thanks,
//richard

      parent reply	other threads:[~2014-06-24  6:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53A7EF04.7040805@denx.de>
     [not found] ` <53A809A3.30703@denx.de>
2014-06-23 11:58   ` UBI: fix rb_tree node comparison in add_map commit buggy? Richard Weinberger
2014-06-23 12:41   ` Richard Weinberger
2014-06-23 13:05     ` Heiko Schocher
2014-06-23 19:07       ` Richard Weinberger
2014-06-24  4:59         ` Artem Bityutskiy
2014-06-24  5:26           ` Heiko Schocher
2014-06-24  5:31             ` Artem Bityutskiy
2014-06-24  6:52               ` Richard Weinberger
2014-06-24  6:53           ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A92059.5080406@nod.at \
    --to=richard@nod.at \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=hs@denx.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.