Re: [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache

[Lei Li <lilei@linux.vnet.ibm.com>]

On 06/23/2014 05:23 PM, Michal Hocko wrote:
> On Mon 23-06-14 17:11:19, Lei Li wrote:
>> remove_from_page_cache has been renamed to delete_from_page_cache
>> since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
>> to it in Memcg documentation.
>>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> This conflicts with the current mmotm tree because of Johannes' {un}charge rewrite.
> Anyway the comment is not up-to-date anyway. __delete_from_page_cache is
> called from more places and I do not see quite a good reason why to keep
> this in the documentation.
> I would just remove this note as it doesn't serve any useful purpose.

Thanks for your reply.
Just take a quick look at Johannes' patch of rewriting uncharge API. I'll
resend a patch with the note removed.


Thanks,

Lei

>
>> ---
>>   Documentation/cgroups/memcg_test.txt | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
>> index 80ac454..b2d6ccc 100644
>> --- a/Documentation/cgroups/memcg_test.txt
>> +++ b/Documentation/cgroups/memcg_test.txt
>> @@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
>>   	- add_to_page_cache_locked().
>>   
>>   	uncharged at
>> -	- __remove_from_page_cache().
>> +	- __delete_from_page_cache().
>>   
>>   	The logic is very clear. (About migration, see below)
>> -	Note: __remove_from_page_cache() is called by remove_from_page_cache()
>> +	Note: __delete_from_page_cache() is called by delete_from_page_cache()
>>   	and __remove_mapping().
>>   
>>   6. Shmem(tmpfs) Page Cache
>> -- 
>> 1.8.5.3
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>