From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree
Date: Tue, 24 Jun 2014 10:48:25 +0300 [thread overview]
Message-ID: <53A92D49.9060306@ti.com> (raw)
In-Reply-To: <1403541221-10619-1-git-send-email-fabf@skynet.be>
Hi Fabian,
On 06/23/2014 07:33 PM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
can you send the same patch to alsa-devel with subject:
ASoC: mcbsp: remove unnecessary null test before kfree
You can add my:
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> sound/soc/omap/mcbsp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 86c7538..68a1252 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
> mcbsp->reg_cache = NULL;
> spin_unlock(&mcbsp->lock);
>
> - if (reg_cache)
> - kfree(reg_cache);
> + kfree(reg_cache);
> }
>
> /*
>
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Fabian Frederick <fabf@skynet.be>, <linux-kernel@vger.kernel.org>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree
Date: Tue, 24 Jun 2014 10:48:25 +0300 [thread overview]
Message-ID: <53A92D49.9060306@ti.com> (raw)
In-Reply-To: <1403541221-10619-1-git-send-email-fabf@skynet.be>
Hi Fabian,
On 06/23/2014 07:33 PM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
can you send the same patch to alsa-devel with subject:
ASoC: mcbsp: remove unnecessary null test before kfree
You can add my:
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> sound/soc/omap/mcbsp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 86c7538..68a1252 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
> mcbsp->reg_cache = NULL;
> spin_unlock(&mcbsp->lock);
>
> - if (reg_cache)
> - kfree(reg_cache);
> + kfree(reg_cache);
> }
>
> /*
>
--
Péter
next prev parent reply other threads:[~2014-06-24 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 16:33 [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree Fabian Frederick
2014-06-24 7:48 ` Peter Ujfalusi [this message]
2014-06-24 7:48 ` Peter Ujfalusi
-- strict thread matches above, loose matches on Subject: below --
2014-06-26 14:55 Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A92D49.9060306@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=fabf@skynet.be \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.