From: James Hogan <james.hogan@imgtec.com>
To: Daniel Walter <dwalter@google.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arch/mips rb532: replace mac_addr parsing
Date: Tue, 24 Jun 2014 11:13:33 +0100 [thread overview]
Message-ID: <53A94F4D.10605@imgtec.com> (raw)
In-Reply-To: <20140624084540.GA22930@google.com>
Hi Daniel,
On 24/06/14 09:45, Daniel Walter wrote:
> @@ -333,7 +311,13 @@ static int __init plat_setup_devices(void)
> static int __init setup_kmac(char *s)
> {
> printk(KERN_INFO "korina mac = %s\n", s);
> - parse_mac_addr(s);
> + sscanf(s, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> + &korina_dev0_data.mac[0],
> + &korina_dev0_data.mac[1],
> + &korina_dev0_data.mac[2],
> + &korina_dev0_data.mac[3],
> + &korina_dev0_data.mac[4],
> + &korina_dev0_data.mac[5]);
Does it make sense to go one better and use mac_pton() for this?
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Daniel Walter <dwalter@google.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arch/mips rb532: replace mac_addr parsing
Date: Tue, 24 Jun 2014 11:13:33 +0100 [thread overview]
Message-ID: <53A94F4D.10605@imgtec.com> (raw)
Message-ID: <20140624101333.JaGxc426iwZfjGdgQFtlZ8Ovgooak5FCIQ___wgBNS4@z> (raw)
In-Reply-To: <20140624084540.GA22930@google.com>
Hi Daniel,
On 24/06/14 09:45, Daniel Walter wrote:
> @@ -333,7 +311,13 @@ static int __init plat_setup_devices(void)
> static int __init setup_kmac(char *s)
> {
> printk(KERN_INFO "korina mac = %s\n", s);
> - parse_mac_addr(s);
> + sscanf(s, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> + &korina_dev0_data.mac[0],
> + &korina_dev0_data.mac[1],
> + &korina_dev0_data.mac[2],
> + &korina_dev0_data.mac[3],
> + &korina_dev0_data.mac[4],
> + &korina_dev0_data.mac[5]);
Does it make sense to go one better and use mac_pton() for this?
Cheers
James
next prev parent reply other threads:[~2014-06-24 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 8:45 [PATCH v2] arch/mips rb532: replace mac_addr parsing Daniel Walter
2014-06-24 10:13 ` James Hogan [this message]
2014-06-24 10:13 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A94F4D.10605@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=dwalter@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.