[Qemu-devel] [PATCH 0/2] target-ppc: fix unused-function warnings

[Qemu-devel] [PATCH 0/2] target-ppc: fix unused-function warnings

[Peter Maydell]

These patches for target-ppc fix clang 3.4 warnings about
'static inline' functions which are defined but never used.

(Incidentally, "d" is a terrible name for a function, so
we're well rid of that one :-))

thanks
-- PMM

Peter Maydell (2):
  target-ppc: Remove unused IMM and d extract helpers
  target-ppc: Remove unused gen_qemu_ld8s()

 target-ppc/translate.c | 8 --------
 1 file changed, 8 deletions(-)

-- 
2.0.0

[Qemu-devel] [PATCH 1/2] target-ppc: Remove unused IMM and d extract helpers

[Peter Maydell]

Remove the definition of the IMM and d extract helpers; these seem to have
been added as part of the initial PPC support in 2003 but never actually
used.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-ppc/translate.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 4801721..4099cdc 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -426,7 +426,6 @@ static inline uint32_t SPR(uint32_t opcode)
     return ((sprn >> 5) & 0x1F) | ((sprn & 0x1F) << 5);
 }
 /***                              Get constants                            ***/
-EXTRACT_HELPER(IMM, 12, 8);
 /* 16 bits signed immediate value */
 EXTRACT_SHELPER(SIMM, 0, 16);
 /* 16 bits unsigned immediate value */
@@ -459,8 +458,6 @@ EXTRACT_HELPER(FPFLM, 17, 8);
 EXTRACT_HELPER(FPW, 16, 1);
 
 /***                            Jump target decoding                       ***/
-/* Displacement */
-EXTRACT_SHELPER(d, 0, 16);
 /* Immediate address */
 static inline target_ulong LI(uint32_t opcode)
 {
-- 
2.0.0

[Qemu-devel] [PATCH 2/2] target-ppc: Remove unused gen_qemu_ld8s()

[Peter Maydell]

The gen_qemu_ld8s() function is unused; remove it.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-ppc/translate.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 4099cdc..aa835a2 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -2662,11 +2662,6 @@ static inline void gen_qemu_ld8u(DisasContext *ctx, TCGv arg1, TCGv arg2)
     tcg_gen_qemu_ld8u(arg1, arg2, ctx->mem_idx);
 }
 
-static inline void gen_qemu_ld8s(DisasContext *ctx, TCGv arg1, TCGv arg2)
-{
-    tcg_gen_qemu_ld8s(arg1, arg2, ctx->mem_idx);
-}
-
 static inline void gen_qemu_ld16u(DisasContext *ctx, TCGv arg1, TCGv arg2)
 {
     TCGMemOp op = MO_UW | ctx->default_tcg_memop_mask;
-- 
2.0.0

Re: [Qemu-devel] [PATCH 0/2] target-ppc: fix unused-function warnings

[Alexander Graf]

On 24.06.14 01:05, Peter Maydell wrote:
> These patches for target-ppc fix clang 3.4 warnings about
> 'static inline' functions which are defined but never used.
>
> (Incidentally, "d" is a terrible name for a function, so
> we're well rid of that one :-))

Thanks, applied to ppc-next :).

As for "d" - that's unfortunately how the spec calls the field ;).


Alex