All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Mihai Caraman <mihai.caraman@freescale.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH v4] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule
Date: Tue, 24 Jun 2014 12:12:43 +0000	[thread overview]
Message-ID: <53A96B3B.7070601@suse.de> (raw)
In-Reply-To: <1403075722-11151-1-git-send-email-mihai.caraman@freescale.com>


On 18.06.14 09:15, Mihai Caraman wrote:
> On vcpu schedule, the condition checked for tlb pollution is too loose.
> The tlb entries of a vcpu become polluted (vs stale) only when a different
> vcpu within the same logical partition runs in-between. Optimize the tlb
> invalidation condition keeping last_vcpu per logical partition id.
>
> With the new invalidation condition, a guest shows 4% performance improvement
> on P5020DS while running a memory stress application with the cpu oversubscribed,
> the other guest running a cpu intensive workload.
>
> Guest - old invalidation condition
>    real 3.89
>    user 3.87
>    sys 0.01
>
> Guest - enhanced invalidation condition
>    real 3.75
>    user 3.73
>    sys 0.01
>
> Host
>    real 3.70
>    user 1.85
>    sys 0.00
>
> The memory stress application accesses 4KB pages backed by 75% of available
> TLB0 entries:
>
> char foo[ENTRIES][4096] __attribute__ ((aligned (4096)));
>
> int main()
> {
> 	char bar;
> 	int i, j;
>
> 	for (i = 0; i < ITERATIONS; i++)
>          	for (j = 0; j < ENTRIES; j++)
>              		bar = foo[j][0];
>
> 	return 0;
> }
>
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> Cc: Scott Wood <scottwood@freescale.com>

Thanks, applied to kvm-ppc-queue.


Alex


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Mihai Caraman <mihai.caraman@freescale.com>, kvm-ppc@vger.kernel.org
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org
Subject: Re: [PATCH v4] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule
Date: Tue, 24 Jun 2014 14:12:43 +0200	[thread overview]
Message-ID: <53A96B3B.7070601@suse.de> (raw)
In-Reply-To: <1403075722-11151-1-git-send-email-mihai.caraman@freescale.com>


On 18.06.14 09:15, Mihai Caraman wrote:
> On vcpu schedule, the condition checked for tlb pollution is too loose.
> The tlb entries of a vcpu become polluted (vs stale) only when a different
> vcpu within the same logical partition runs in-between. Optimize the tlb
> invalidation condition keeping last_vcpu per logical partition id.
>
> With the new invalidation condition, a guest shows 4% performance improvement
> on P5020DS while running a memory stress application with the cpu oversubscribed,
> the other guest running a cpu intensive workload.
>
> Guest - old invalidation condition
>    real 3.89
>    user 3.87
>    sys 0.01
>
> Guest - enhanced invalidation condition
>    real 3.75
>    user 3.73
>    sys 0.01
>
> Host
>    real 3.70
>    user 1.85
>    sys 0.00
>
> The memory stress application accesses 4KB pages backed by 75% of available
> TLB0 entries:
>
> char foo[ENTRIES][4096] __attribute__ ((aligned (4096)));
>
> int main()
> {
> 	char bar;
> 	int i, j;
>
> 	for (i = 0; i < ITERATIONS; i++)
>          	for (j = 0; j < ENTRIES; j++)
>              		bar = foo[j][0];
>
> 	return 0;
> }
>
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> Cc: Scott Wood <scottwood@freescale.com>

Thanks, applied to kvm-ppc-queue.


Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Mihai Caraman <mihai.caraman@freescale.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH v4] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule
Date: Tue, 24 Jun 2014 14:12:43 +0200	[thread overview]
Message-ID: <53A96B3B.7070601@suse.de> (raw)
In-Reply-To: <1403075722-11151-1-git-send-email-mihai.caraman@freescale.com>


On 18.06.14 09:15, Mihai Caraman wrote:
> On vcpu schedule, the condition checked for tlb pollution is too loose.
> The tlb entries of a vcpu become polluted (vs stale) only when a different
> vcpu within the same logical partition runs in-between. Optimize the tlb
> invalidation condition keeping last_vcpu per logical partition id.
>
> With the new invalidation condition, a guest shows 4% performance improvement
> on P5020DS while running a memory stress application with the cpu oversubscribed,
> the other guest running a cpu intensive workload.
>
> Guest - old invalidation condition
>    real 3.89
>    user 3.87
>    sys 0.01
>
> Guest - enhanced invalidation condition
>    real 3.75
>    user 3.73
>    sys 0.01
>
> Host
>    real 3.70
>    user 1.85
>    sys 0.00
>
> The memory stress application accesses 4KB pages backed by 75% of available
> TLB0 entries:
>
> char foo[ENTRIES][4096] __attribute__ ((aligned (4096)));
>
> int main()
> {
> 	char bar;
> 	int i, j;
>
> 	for (i = 0; i < ITERATIONS; i++)
>          	for (j = 0; j < ENTRIES; j++)
>              		bar = foo[j][0];
>
> 	return 0;
> }
>
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> Cc: Scott Wood <scottwood@freescale.com>

Thanks, applied to kvm-ppc-queue.


Alex

  parent reply	other threads:[~2014-06-24 12:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  7:15 [PATCH v4] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule Mihai Caraman
2014-06-18  7:15 ` Mihai Caraman
2014-06-18  7:15 ` Mihai Caraman
2014-06-18 17:21 ` Scott Wood
2014-06-18 17:21   ` Scott Wood
2014-06-18 17:21   ` Scott Wood
2014-06-24 12:12 ` Alexander Graf [this message]
2014-06-24 12:12   ` Alexander Graf
2014-06-24 12:12   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A96B3B.7070601@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mihai.caraman@freescale.com \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.