* [lm-sensors] [PATCH] hwmon: (w83l786ng) Report correct minimum fan speed
@ 2014-06-25 1:02 Axel Lin
2014-06-25 1:39 ` Kevin Lo
2014-06-25 2:21 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-06-25 1:02 UTC (permalink / raw)
To: lm-sensors
Current code is buggy, it shows the current fan speed as minimum fan speed.
Fix up show_fan_reg macro to correctly report fan and fan_min speed.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/hwmon/w83l786ng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/w83l786ng.c b/drivers/hwmon/w83l786ng.c
index 6ed76ce..32487c1 100644
--- a/drivers/hwmon/w83l786ng.c
+++ b/drivers/hwmon/w83l786ng.c
@@ -249,7 +249,7 @@ static ssize_t show_##reg(struct device *dev, struct device_attribute *attr, \
int nr = to_sensor_dev_attr(attr)->index; \
struct w83l786ng_data *data = w83l786ng_update_device(dev); \
return sprintf(buf, "%d\n", \
- FAN_FROM_REG(data->fan[nr], DIV_FROM_REG(data->fan_div[nr]))); \
+ FAN_FROM_REG(data->reg[nr], DIV_FROM_REG(data->fan_div[nr]))); \
}
show_fan_reg(fan);
--
1.8.3.2
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (w83l786ng) Report correct minimum fan speed
2014-06-25 1:02 [lm-sensors] [PATCH] hwmon: (w83l786ng) Report correct minimum fan speed Axel Lin
@ 2014-06-25 1:39 ` Kevin Lo
2014-06-25 2:21 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Lo @ 2014-06-25 1:39 UTC (permalink / raw)
To: lm-sensors
On Wed, Jun 25, 2014 at 09:02:32AM +0800, Axel Lin wrote:
>
> Current code is buggy, it shows the current fan speed as minimum fan speed.
> Fix up show_fan_reg macro to correctly report fan and fan_min speed.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Looks good to me, thanks.
Acked-by: Kevin Lo <kevlo@kevlo.org>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (w83l786ng) Report correct minimum fan speed
2014-06-25 1:02 [lm-sensors] [PATCH] hwmon: (w83l786ng) Report correct minimum fan speed Axel Lin
2014-06-25 1:39 ` Kevin Lo
@ 2014-06-25 2:21 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-06-25 2:21 UTC (permalink / raw)
To: lm-sensors
On 06/24/2014 06:02 PM, Axel Lin wrote:
> Current code is buggy, it shows the current fan speed as minimum fan speed.
> Fix up show_fan_reg macro to correctly report fan and fan_min speed.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
Applied to -next.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-25 2:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 1:02 [lm-sensors] [PATCH] hwmon: (w83l786ng) Report correct minimum fan speed Axel Lin
2014-06-25 1:39 ` Kevin Lo
2014-06-25 2:21 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.