From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "bhupesh.sharma@freescale.com" <bhupesh.sharma@freescale.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: "wg@grandegger.com" <wg@grandegger.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: can: Remodel FlexCAN register read/write APIs for BE instances
Date: Wed, 25 Jun 2014 13:07:48 +0200 [thread overview]
Message-ID: <53AAAD84.1010400@pengutronix.de> (raw)
In-Reply-To: <536c077e2e8b4dfabb4c07f696753a3c@BN1PR03MB220.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On 06/25/2014 01:01 PM, bhupesh.sharma@freescale.com wrote:
>> What about function pointers in the priv? So that flexcan_read() becomes
>> priv->read().
> That's what I propose (similar to what I did for C_CAN driver for 16-bit and 32-bit
> reg interfaces using platform data):
Yes...but...
> bool module_is_be = false;
...module_is_be is not that simple, on PPC true must be the default to
be compatible with existing dts.
> module_is_be = get-endianess-from-DT-node;
>
> priv->read() = module_is_be ? flexcan_read_be : flexcan_read_le;
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-06-25 11:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 15:54 [PATCH] net: can: Remodel FlexCAN register read/write APIs for BE instances Bhupesh Sharma
2014-06-24 15:54 ` Bhupesh Sharma
2014-06-25 8:27 ` Marc Kleine-Budde
2014-06-25 9:41 ` bhupesh.sharma
2014-06-25 10:26 ` Marc Kleine-Budde
2014-06-25 11:01 ` bhupesh.sharma
2014-06-25 11:07 ` Marc Kleine-Budde [this message]
2014-06-25 14:16 ` bhupesh.sharma
2014-06-25 19:00 ` Marc Kleine-Budde
2014-06-26 9:28 ` Marc Kleine-Budde
2014-06-26 9:30 ` bhupesh.sharma
2014-06-26 9:35 ` Marc Kleine-Budde
2014-06-25 10:29 ` David Laight
2014-06-25 10:34 ` Marc Kleine-Budde
2014-06-25 8:58 ` David Laight
2014-06-25 9:55 ` bhupesh.sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAAD84.1010400@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=bhupesh.sharma@freescale.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.