From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Russell King <linux@arm.linux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] sched: Fix compiler warnings
Date: Wed, 25 Jun 2014 08:03:46 -0700 [thread overview]
Message-ID: <53AAE4D2.5020104@roeck-us.net> (raw)
In-Reply-To: <20140625144955.GP14781@pengutronix.de>
On 06/25/2014 07:49 AM, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Wed, Jun 25, 2014 at 07:27:47AM -0700, Guenter Roeck wrote:
>>> Maybe the author's intention was:
>>>
>>> static inline int cpu_corepower_flags(void) __attribute__((const));
>>>
>>> ?
>>> This specifies that the function has no side effects and the return value
>>> only depends on the (here non-existing) function arguments.
>>>
>>
>> Possibly, but either I am missing something or this doesn't compile.
> You need to do a separate declaration:
>
> static inline int cpu_corepower_flags(void) __attribute__((const));
> static inline int cpu_corepower_flags(void)
> {
> ...
Actually turns out one can use __attribute_const__, and it is
static inline int __attribute_const__ cpu_corepower_flags(void)
which turns out to be widely used.
I'll change that and resubmit after testing.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] sched: Fix compiler warnings
Date: Wed, 25 Jun 2014 08:03:46 -0700 [thread overview]
Message-ID: <53AAE4D2.5020104@roeck-us.net> (raw)
In-Reply-To: <20140625144955.GP14781@pengutronix.de>
On 06/25/2014 07:49 AM, Uwe Kleine-K?nig wrote:
> Hello Guenter,
>
> On Wed, Jun 25, 2014 at 07:27:47AM -0700, Guenter Roeck wrote:
>>> Maybe the author's intention was:
>>>
>>> static inline int cpu_corepower_flags(void) __attribute__((const));
>>>
>>> ?
>>> This specifies that the function has no side effects and the return value
>>> only depends on the (here non-existing) function arguments.
>>>
>>
>> Possibly, but either I am missing something or this doesn't compile.
> You need to do a separate declaration:
>
> static inline int cpu_corepower_flags(void) __attribute__((const));
> static inline int cpu_corepower_flags(void)
> {
> ...
Actually turns out one can use __attribute_const__, and it is
static inline int __attribute_const__ cpu_corepower_flags(void)
which turns out to be widely used.
I'll change that and resubmit after testing.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Russell King <linux@arm.linux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linuxppc-dev@lists.ozlabs.org,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] sched: Fix compiler warnings
Date: Wed, 25 Jun 2014 08:03:46 -0700 [thread overview]
Message-ID: <53AAE4D2.5020104@roeck-us.net> (raw)
In-Reply-To: <20140625144955.GP14781@pengutronix.de>
On 06/25/2014 07:49 AM, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Wed, Jun 25, 2014 at 07:27:47AM -0700, Guenter Roeck wrote:
>>> Maybe the author's intention was:
>>>
>>> static inline int cpu_corepower_flags(void) __attribute__((const));
>>>
>>> ?
>>> This specifies that the function has no side effects and the return value
>>> only depends on the (here non-existing) function arguments.
>>>
>>
>> Possibly, but either I am missing something or this doesn't compile.
> You need to do a separate declaration:
>
> static inline int cpu_corepower_flags(void) __attribute__((const));
> static inline int cpu_corepower_flags(void)
> {
> ...
Actually turns out one can use __attribute_const__, and it is
static inline int __attribute_const__ cpu_corepower_flags(void)
which turns out to be widely used.
I'll change that and resubmit after testing.
Guenter
next prev parent reply other threads:[~2014-06-25 15:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 1:05 [PATCH v2] sched: Fix compiler warnings Guenter Roeck
2014-06-25 1:05 ` Guenter Roeck
2014-06-25 1:05 ` Guenter Roeck
2014-06-25 1:23 ` Benjamin Herrenschmidt
2014-06-25 1:23 ` Benjamin Herrenschmidt
2014-06-25 1:23 ` Benjamin Herrenschmidt
2014-06-25 6:41 ` Vincent Guittot
2014-06-25 6:41 ` Vincent Guittot
2014-06-25 6:41 ` Vincent Guittot
2014-06-25 7:14 ` Uwe Kleine-König
2014-06-25 7:14 ` Uwe Kleine-König
2014-06-25 7:14 ` Uwe Kleine-König
2014-06-25 14:27 ` Guenter Roeck
2014-06-25 14:27 ` Guenter Roeck
2014-06-25 14:27 ` Guenter Roeck
2014-06-25 14:49 ` Uwe Kleine-König
2014-06-25 14:49 ` Uwe Kleine-König
2014-06-25 14:49 ` Uwe Kleine-König
2014-06-25 15:03 ` Guenter Roeck [this message]
2014-06-25 15:03 ` Guenter Roeck
2014-06-25 15:03 ` Guenter Roeck
2014-06-25 15:40 ` David Laight
2014-06-25 15:40 ` David Laight
2014-06-25 15:40 ` David Laight
2014-06-25 15:52 ` Uwe Kleine-König
2014-06-25 15:52 ` Uwe Kleine-König
2014-06-25 15:52 ` Uwe Kleine-König
2014-06-25 16:04 ` David Laight
2014-06-25 16:04 ` David Laight
2014-06-25 16:04 ` David Laight
2014-06-25 16:09 ` Guenter Roeck
2014-06-25 16:09 ` Guenter Roeck
2014-06-25 16:09 ` Guenter Roeck
2014-06-26 0:59 ` Stephen Rothwell
2014-06-26 0:59 ` Stephen Rothwell
2014-06-26 0:59 ` Stephen Rothwell
2014-06-26 3:27 ` Guenter Roeck
2014-06-26 3:27 ` Guenter Roeck
2014-06-26 3:27 ` Guenter Roeck
2014-07-02 6:37 ` [tip:sched/urgent] " tip-bot for Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAE4D2.5020104@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.