From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/1] fs/gfs2/lock_dlm.c: replace count*size kzalloc by kcalloc
Date: Thu, 26 Jun 2014 12:04:30 +0100 [thread overview]
Message-ID: <53ABFE3E.80500@redhat.com> (raw)
In-Reply-To: <1403721645-19455-1-git-send-email-fabf@skynet.be>
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 25/06/14 19:40, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: cluster-devel at redhat.com
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/gfs2/lock_dlm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
> index 91f274d..4fafea1 100644
> --- a/fs/gfs2/lock_dlm.c
> +++ b/fs/gfs2/lock_dlm.c
> @@ -1036,8 +1036,8 @@ static int set_recover_size(struct gfs2_sbd *sdp, struct dlm_slot *slots,
>
> new_size = old_size + RECOVER_SIZE_INC;
>
> - submit = kzalloc(new_size * sizeof(uint32_t), GFP_NOFS);
> - result = kzalloc(new_size * sizeof(uint32_t), GFP_NOFS);
> + submit = kcalloc(new_size, sizeof(uint32_t), GFP_NOFS);
> + result = kcalloc(new_size, sizeof(uint32_t), GFP_NOFS);
> if (!submit || !result) {
> kfree(submit);
> kfree(result);
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: cluster-devel@redhat.com
Subject: Re: [PATCH 1/1] fs/gfs2/lock_dlm.c: replace count*size kzalloc by kcalloc
Date: Thu, 26 Jun 2014 12:04:30 +0100 [thread overview]
Message-ID: <53ABFE3E.80500@redhat.com> (raw)
In-Reply-To: <1403721645-19455-1-git-send-email-fabf@skynet.be>
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 25/06/14 19:40, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: cluster-devel@redhat.com
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/gfs2/lock_dlm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
> index 91f274d..4fafea1 100644
> --- a/fs/gfs2/lock_dlm.c
> +++ b/fs/gfs2/lock_dlm.c
> @@ -1036,8 +1036,8 @@ static int set_recover_size(struct gfs2_sbd *sdp, struct dlm_slot *slots,
>
> new_size = old_size + RECOVER_SIZE_INC;
>
> - submit = kzalloc(new_size * sizeof(uint32_t), GFP_NOFS);
> - result = kzalloc(new_size * sizeof(uint32_t), GFP_NOFS);
> + submit = kcalloc(new_size, sizeof(uint32_t), GFP_NOFS);
> + result = kcalloc(new_size, sizeof(uint32_t), GFP_NOFS);
> if (!submit || !result) {
> kfree(submit);
> kfree(result);
next prev parent reply other threads:[~2014-06-26 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 18:40 [Cluster-devel] [PATCH 1/1] fs/gfs2/lock_dlm.c: replace count*size kzalloc by kcalloc Fabian Frederick
2014-06-25 18:40 ` Fabian Frederick
2014-06-26 11:04 ` Steven Whitehouse [this message]
2014-06-26 11:04 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ABFE3E.80500@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.