From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
Date: Thu, 26 Jun 2014 12:47:55 +0100 [thread overview]
Message-ID: <53AC086B.80406@linaro.org> (raw)
In-Reply-To: <1403782369-10201-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 26/06/14 12:32, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..f4ee1b1 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
> func = &info->functions[index];
> func->name = np->name;
> func->ngroups = of_get_child_count(np);
> - if (func->ngroups <= 0) {
> + if (func->ngroups == 0) {
Makes sense
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> dev_err(info->dev, "No groups defined\n");
> return -EINVAL;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>
Cc: devicetree@vger.kernel.org, kernel@stlinux.com,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
Date: Thu, 26 Jun 2014 12:47:55 +0100 [thread overview]
Message-ID: <53AC086B.80406@linaro.org> (raw)
In-Reply-To: <1403782369-10201-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 26/06/14 12:32, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..f4ee1b1 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
> func = &info->functions[index];
> func->name = np->name;
> func->ngroups = of_get_child_count(np);
> - if (func->ngroups <= 0) {
> + if (func->ngroups == 0) {
Makes sense
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> dev_err(info->dev, "No groups defined\n");
> return -EINVAL;
> }
>
next prev parent reply other threads:[~2014-06-26 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 11:32 [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero Rickard Strandqvist
2014-06-26 11:32 ` Rickard Strandqvist
2014-06-26 11:32 ` Rickard Strandqvist
2014-06-26 11:47 ` Srinivas Kandagatla [this message]
2014-06-26 11:47 ` Srinivas Kandagatla
2014-06-26 12:03 ` Maxime Coquelin
2014-06-26 12:03 ` Maxime Coquelin
2014-06-26 12:03 ` Maxime Coquelin
2014-07-07 15:42 ` Linus Walleij
2014-07-07 15:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC086B.80406@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.