From: Eric Blake <eblake@redhat.com>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 1/4] block: Support Archipelago as a QEMU block backend
Date: Thu, 26 Jun 2014 09:06:03 -0600 [thread overview]
Message-ID: <53AC36DB.8090009@redhat.com> (raw)
In-Reply-To: <1403526734-29237-2-git-send-email-cnanakos@grnet.gr>
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote:
> VM Image on Archipelago volume is specified like this:
>
> file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>][:
> segment=<segment_name>]]
>
> or
>
> file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[,
> file.vport=<vlmcd_port>][,file.segment=<segment_name>]]
>
I still plan to review this series in full, but my quick pre-review comment:
on version 2, Markus suggested that you should separate the patch that
adds QMP structured options (first) from the patch that adds syntactic
sugar
file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]] (second)
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00269.html
and I stand by his suggestion, although I don't see that split here yet.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-26 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 12:32 [Qemu-devel] [PATCH v5 0/4] Support Archipelago as a QEMU block backend Chrysostomos Nanakos
2014-06-23 12:32 ` [Qemu-devel] [PATCH v5 1/4] block: " Chrysostomos Nanakos
2014-06-26 15:06 ` Eric Blake [this message]
2014-06-26 16:14 ` Chrysostomos Nanakos
2014-06-23 12:32 ` [Qemu-devel] [PATCH v5 2/4] block/archipelago: Add support for creating images Chrysostomos Nanakos
2014-06-23 12:32 ` [Qemu-devel] [PATCH v5 3/4] QMP: Add support for Archipelago Chrysostomos Nanakos
2014-06-23 12:32 ` [Qemu-devel] [PATCH v5 4/4] qemu-iotests: add support for Archipelago protocol Chrysostomos Nanakos
2014-06-23 12:47 ` [Qemu-devel] [PATCH v6 " Chrysostomos Nanakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AC36DB.8090009@redhat.com \
--to=eblake@redhat.com \
--cc=cnanakos@grnet.gr \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.