All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>,
	famz@redhat.com, qemu-devel@nongnu.org,
	Wenchao Xia <wenchaoqemu@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt
Date: Thu, 26 Jun 2014 10:25:16 -0600	[thread overview]
Message-ID: <53AC496C.6040802@redhat.com> (raw)
In-Reply-To: <53AC1F4D.6090702@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

On 06/26/2014 07:25 AM, Paolo Bonzini wrote:
> Il 26/06/2014 15:17, Luiz Capitulino ha scritto:
>>> > We're really close to hard freeze and by extension the release.  Do
>>> > _not_ strive for perfection.  Get something that is mostly okay and is
>>> > an obvious patch.  We'll then have 3 weeks to do documentation
>>> patches.
>> The hard freeze argument is a strong one, but my understanding was that
>> we wanted to move away from duplicated information. So reverting is a
>> step back.
> 
> We sure want to move away from duplicated information.  However, at this
> point we are actively _dropping_ information compared to qmp-events.txt
> (the examples).
> 
> Considering that QEMU releases rarely add more than 1 event(*), the
> amount of duplicated work caused by qmp-events.txt is trivial for the
> foreseeable future.

Actually, there is a second new event on queue right now:
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg06561.html

> 
> Of course, the obvious steps to do things "right" are:
> 
> - automatically generate HTML/DocBook/Texinfo documentation from .json
> 
> - install the automatically-generated documentation
> 
> - move examples from qmp-events.txt and qmp-commands.hx to the .json
> 
> - when qmp-events.txt and qmp-commands.hx are entirely duplicate, kill them
> 
> But this requires manpower, of course.

Sadly, manpower is more frequently devoted to code than to documentation
improvements.

> 
> Paolo
> 
> (*)    Version         Events introduced
>        0.12.0                5
>        0.13.0                5
>        0.14.0                3
>        0.15.0                0
>        1.0                   0
>        1.1                   2
>        1.2                   2
>        1.3                   1
>        1.4                   0
>        1.5                   1
>        1.6                   1
>        1.7                   0
>        2.0                   1
>        2.1                   1

So depending on Laszlo's series, we may be adding 2 events in 2.1.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2014-06-26 16:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25  9:30 [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt Michal Privoznik
2014-06-25  9:34 ` Paolo Bonzini
2014-06-25  9:37   ` Michal Privoznik
2014-06-25 13:56 ` Eric Blake
2014-06-25 17:21   ` Markus Armbruster
2014-06-25 19:50   ` Luiz Capitulino
2014-06-25 20:13     ` Eric Blake
2014-06-26 12:46       ` Luiz Capitulino
2014-06-26 13:01         ` Paolo Bonzini
2014-06-26 13:11           ` Eric Blake
2014-06-26 13:14             ` Paolo Bonzini
2014-06-26 13:17               ` Luiz Capitulino
2014-06-26 13:25                 ` Paolo Bonzini
2014-06-26 13:43                   ` [Qemu-devel] [PATCH] qmp: add qmp-events.txt back Luiz Capitulino
2014-06-26 13:56                     ` Paolo Bonzini
2014-06-26 16:31                     ` Eric Blake
2014-06-26 16:25                   ` Eric Blake [this message]
2014-06-26 16:27                     ` [Qemu-devel] [PATCH] Makefile: Install qmp-events.txt Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AC496C.6040802@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mprivozn@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wenchaoqemu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.