Re: [Qemu-devel] [PATCH] qmp: add qmp-events.txt back

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

On 06/26/2014 07:43 AM, Luiz Capitulino wrote:

> Fair enough. Here goes the patch. As each commit dropped a section of the
> file, it was easier just to re-add it. ACKs wanted.
> 
> Subject: [PATCH] qmp: add qmp-events.txt back
> 
> The conversion of events to the QAPI, resulted in the removal of the
> docs/qmp/qmp-events.txt file. This was done to avoid having duplicated
> information between qmp-events.txt and qapi-event.json.
> 
> However, qmp-events.txt contains examples and we're still not sure
> how to proper install QAPI docs in the host. To avoid harming users,
> it's better to re-add qmp-events.txt for now and deal with the
> duplication later.

We'll need some followup patches to fix typos, missing events, and such
to be in parallel with the schema; but a straight revive of the file to
the pre-conversion state is the easiest starting point for those followups.

> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  docs/qmp/qmp-events.txt | 551 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 551 insertions(+)
>  create mode 100644 docs/qmp/qmp-events.txt
> 
> diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> new file mode 100644
> index 0000000..22fea58

I'm happy that this is a straight revive, based on the output of
 git ls-tree 506f40ff:docs/qmp/
 git show 506f40ff  # patch 1 of the conversion series

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]