From: patrice.chotard@st.com (Patrice Chotard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
Date: Fri, 27 Jun 2014 08:47:04 +0200 [thread overview]
Message-ID: <53AD1368.8020305@st.com> (raw)
In-Reply-To: <1403790272-11635-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Hi Rickard
On 06/26/2014 03:44 PM, Rickard Strandqvist wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..d3bd687 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> const __be32 *list;
> struct property *pp;
> struct st_pinconf *conf;
> - phandle phandle;
> struct device_node *pins;
> - u32 pin;
> int i = 0, npins = 0, nr_props;
>
> pins = of_get_child_by_name(np, "st,pins");
> @@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> conf = &grp->pin_conf[i];
>
> /* bank & offset */
> - phandle = be32_to_cpup(list++);
> - pin = be32_to_cpup(list++);
> + be32_to_cpup(list++);
> + be32_to_cpup(list++);
> conf->pin = of_get_named_gpio(pins, pp->name, 0);
> conf->name = pp->name;
> grp->pins[i] = conf->pin;
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Patrice Chotard <patrice.chotard@st.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
Date: Fri, 27 Jun 2014 08:47:04 +0200 [thread overview]
Message-ID: <53AD1368.8020305@st.com> (raw)
In-Reply-To: <1403790272-11635-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Hi Rickard
On 06/26/2014 03:44 PM, Rickard Strandqvist wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..d3bd687 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> const __be32 *list;
> struct property *pp;
> struct st_pinconf *conf;
> - phandle phandle;
> struct device_node *pins;
> - u32 pin;
> int i = 0, npins = 0, nr_props;
>
> pins = of_get_child_by_name(np, "st,pins");
> @@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> conf = &grp->pin_conf[i];
>
> /* bank & offset */
> - phandle = be32_to_cpup(list++);
> - pin = be32_to_cpup(list++);
> + be32_to_cpup(list++);
> + be32_to_cpup(list++);
> conf->pin = of_get_named_gpio(pins, pp->name, 0);
> conf->name = pp->name;
> grp->pins[i] = conf->pin;
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Patrice Chotard <patrice.chotard@st.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Maxime Coquelin <maxime.coquelin@st.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used
Date: Fri, 27 Jun 2014 08:47:04 +0200 [thread overview]
Message-ID: <53AD1368.8020305@st.com> (raw)
In-Reply-To: <1403790272-11635-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Hi Rickard
On 06/26/2014 03:44 PM, Rickard Strandqvist wrote:
> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/pinctrl/pinctrl-st.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..d3bd687 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1178,9 +1178,7 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> const __be32 *list;
> struct property *pp;
> struct st_pinconf *conf;
> - phandle phandle;
> struct device_node *pins;
> - u32 pin;
> int i = 0, npins = 0, nr_props;
>
> pins = of_get_child_by_name(np, "st,pins");
> @@ -1218,8 +1216,8 @@ static int st_pctl_dt_parse_groups(struct device_node *np,
> conf = &grp->pin_conf[i];
>
> /* bank & offset */
> - phandle = be32_to_cpup(list++);
> - pin = be32_to_cpup(list++);
> + be32_to_cpup(list++);
> + be32_to_cpup(list++);
> conf->pin = of_get_named_gpio(pins, pp->name, 0);
> conf->name = pp->name;
> grp->pins[i] = conf->pin;
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
next prev parent reply other threads:[~2014-06-27 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 13:44 [PATCH] pinctrl: pinctrl-st.c: Cleaning up values that are never used Rickard Strandqvist
2014-06-26 13:44 ` Rickard Strandqvist
2014-06-27 6:47 ` Patrice Chotard [this message]
2014-06-27 6:47 ` Patrice Chotard
2014-06-27 6:47 ` Patrice Chotard
2014-07-07 15:54 ` Linus Walleij
2014-07-07 15:54 ` Linus Walleij
2014-07-07 15:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD1368.8020305@st.com \
--to=patrice.chotard@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.