From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH v01 2/3] xen/arm: add platform specific definitions for DRA7 evm board
Date: Fri, 27 Jun 2014 15:27:14 +0100 [thread overview]
Message-ID: <53AD7F42.8050500@linaro.org> (raw)
In-Reply-To: <1403871463.25894.63.camel@kazak.uk.xensource.com>
Hi Ian,
On 27/06/14 13:17, Ian Campbell wrote:
>> + /* OMAP Linux kernel handles devices with status "disabled" in a
>> + * weird manner - tries to reset them. While their memory ranges
>> + * are not mapped, this leads to data aborts, so skip these devices
>> + * from DT for dom0.
>> + */
>> + DT_MATCH_NOT_AVAILABLE(),
>
> I think this should be done in common code, either by default (if that
> makes sense) or using a new quirk flag.
Both of these solutions doesn't make sense to me. A device which is not
available should not be touch by the kernel. In most of the case, Linux
ignores a device which is not available (see amba/platform register code).
For instance, some board has the same SOC but with different devices
enabled/disabled. In this case, there is usually a common device tree
with all enabled/disabled, and a specific device tree which override
some properties.
If OMAP does weird thinks with the device tree, then we should keep it
in the platform code.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-06-27 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 11:15 [PATCH v01 0/3] arm: introduce basic DRA7 platform support Andrii Tseglytskyi
2014-06-26 11:15 ` [PATCH v01 1/3] xen:dt: add match for non-available nodes Andrii Tseglytskyi
2014-06-26 16:29 ` Julien Grall
2014-06-30 10:11 ` Ian Campbell
2014-06-26 11:15 ` [PATCH v01 2/3] xen/arm: add platform specific definitions for DRA7 evm board Andrii Tseglytskyi
2014-06-26 16:40 ` Julien Grall
2014-06-27 8:28 ` Andrii Tseglytskyi
2014-06-27 12:17 ` Ian Campbell
2014-06-27 14:27 ` Julien Grall [this message]
2014-06-27 14:47 ` Ian Campbell
2014-06-27 17:50 ` Julien Grall
2014-06-30 10:08 ` Ian Campbell
2014-06-27 15:31 ` Andrii Tseglytskyi
2014-06-26 11:15 ` [PATCH v01 3/3] xen/arm: dra7: Add UART base address for early logging Andrii Tseglytskyi
2014-06-26 16:41 ` Julien Grall
2014-06-27 12:19 ` Ian Campbell
2014-06-26 16:46 ` [PATCH v01 0/3] arm: introduce basic DRA7 platform support Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD7F42.8050500@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=andrii.tseglytskyi@globallogic.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.