From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Lauren Post <Lauren.Post@freescale.com>,
"meta-freescale@yoctoproject.org"
<meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH] imx-vpu: fix checks of IOGetVirtMem() return value
Date: Sat, 28 Jun 2014 08:48:13 -0700 [thread overview]
Message-ID: <53AEE3BD.1050309@boundarydevices.com> (raw)
In-Reply-To: <e60c36f6bd654bf19831dc19580dffb1@BLUPR03MB551.namprd03.prod.outlook.com>
Thanks Lauren.
On 06/28/2014 07:45 AM, Lauren Post wrote:
> The patch is good. Team said they'll push it into our upcoming beta release.
>
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Eric Nelson
> Sent: Saturday, June 21, 2014 12:53 PM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] [meta-fsl-arm][PATCH] imx-vpu: fix checks of IOGetVirtMem() return value
>
> The IOGetVirtMem() routine returns the address of a memory block or -1 (MAP_FAILED) to indicate an error.
>
> Many callers of this routine tested the return value for <= 0 to detect failure, and at least with a 3G/1G memory split configured in the kernel, a negative number (!= -1) is a valid (successful) return value.
>
> Without this patch, the IOSystemInit() will often detect failure incorrectly.
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> ...etVirtMem-returns-1-MAP_FAILED-on-failure.patch | 81 ++++++++++++++++++++++
prev parent reply other threads:[~2014-06-28 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 17:52 [meta-fsl-arm][PATCH] imx-vpu: fix checks of IOGetVirtMem() return value Eric Nelson
2014-06-25 16:18 ` Otavio Salvador
2014-06-25 16:22 ` Eric Nelson
2014-06-26 0:22 ` Lauren Post
2014-06-26 1:03 ` Eric Nelson
2014-06-28 14:45 ` Lauren Post
2014-06-28 15:48 ` Eric Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AEE3BD.1050309@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=Lauren.Post@freescale.com \
--cc=meta-freescale@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.