From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org"
<meta-freescale@yoctoproject.org>,
laci@boundarydevices.com
Subject: Re: [meta-fsl-arm][PATCH V2] libfslvpuwrap_1.0.46: fix IOGetVirtMem calls
Date: Sat, 28 Jun 2014 10:46:39 -0700 [thread overview]
Message-ID: <53AEFF7F.4080904@boundarydevices.com> (raw)
In-Reply-To: <CAP9ODKonUpA2QmvDWd23Jco_YPuMggcWZznmeMfBHY7M1DeWcw@mail.gmail.com>
On 06/28/2014 10:27 AM, Otavio Salvador wrote:
> Hello Eric,
>
> On Sat, Jun 28, 2014 at 2:17 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ...
>> +Subject: [PATCH] vpu_wrapper: fix tests of return value from IOGetVirtMem
>> +
>> +IOGetVirtMem() returns a pointer or specifically -1 (MAP_FAILED)
>> +in the case of failure.
>
> Please extend the commit log with this info. This is much better to
> have it in commit log instead of forcing people to find out what 'fix
> calls' means ;)
>
Okay.
I started to do that, but it felt redundant-redundant...
next prev parent reply other threads:[~2014-06-28 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 17:02 [meta-fsl-arm][PATCH] libfslvpuwrap_1.0.46: fix IOGetVirtMem calls Eric Nelson
2014-06-28 17:11 ` Eric Nelson
2014-06-28 17:25 ` Otavio Salvador
2014-06-28 17:17 ` [meta-fsl-arm][PATCH V2] " Eric Nelson
2014-06-28 17:27 ` Otavio Salvador
2014-06-28 17:46 ` Eric Nelson [this message]
2014-06-28 17:58 ` [meta-fsl-arm][PATCH V3] " Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AEFF7F.4080904@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=laci@boundarydevices.com \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.